all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: mah@everybody.org (Mark A. Hershberger)
Subject: Re: xml.el bug
Date: Thu, 07 Oct 2004 13:58:21 -0400	[thread overview]
Message-ID: <87r7oa4dhe.fsf@weblog.localhost> (raw)
In-Reply-To: <b9y1xgbz68f.fsf@jpl.org> (Katsumi Yamaoka's message of "Thu, 07 Oct 2004 10:06:56 +0900")


[-- Attachment #1.1: Type: text/plain, Size: 1364 bytes --]


(Previous off-list reply said I had already checked in a fix for
this.  I was wrong.)

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> (xml-substitute-special "The chief of Guinea-Bissau's army is killed
> by rebel soldiers in what is described as a &quot;revolt&quot; over
> unpaid wages.")

The following patch backs out some changes I made to deal with xml
entities that expand into XML.  It should fix the problem till I can
get external entities to work.

--- xml.el	05 Oct 2004 20:48:38 -0400	1.37
+++ xml.el	07 Oct 2004 13:49:45 -0400	
@@ -727,14 +727,9 @@
 				(match-string 1 this-part)))))))
 
 	(cond ((null children)
-	       (if (and (eq (length expansion) 1)
-			(stringp (cadr expansion)))
-		   (setq children (concat prev-part expansion))
-		 (if (stringp (car expansion))
+	       ;; FIXME: If we have an entity that expands into XML, this won't work.
 		     (setq children
-			   (list (concat prev-part (car expansion))
-				 (append (cdr expansion))))
-		   (setq children (append expansion prev-part)))))
+		     (concat prev-part expansion)))
 	      ((stringp children)
 	       (if (stringp expansion)
 		   (setq children (concat children prev-part expansion))

-- 
A choice between one man and a shovel, or a dozen men with teaspoons
is clear to me, and I'm sure it is clear to you also.
    -- Zimran Ahmed <http://www.winterspeak.com/>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

      reply	other threads:[~2004-10-07 17:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-07  1:06 xml.el bug Katsumi Yamaoka
2004-10-07 17:58 ` Mark A. Hershberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r7oa4dhe.fsf@weblog.localhost \
    --to=mah@everybody.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.