From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Custom/define-minor-mode problem Date: Wed, 24 Aug 2005 07:33:17 -0400 Message-ID: <87r7cjr2s4.fsf-monnier+emacs@gnu.org> References: <20050822182030.28436.qmail@web60318.mail.yahoo.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1124887159 10032 80.91.229.2 (24 Aug 2005 12:39:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 24 Aug 2005 12:39:19 +0000 (UTC) Cc: Michael Mauger , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 24 14:39:17 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E7uVv-0001fO-MC for ged-emacs-devel@m.gmane.org; Wed, 24 Aug 2005 14:37:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7uZj-00078q-Po for ged-emacs-devel@m.gmane.org; Wed, 24 Aug 2005 08:41:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1E7tdi-00023d-3C for emacs-devel@gnu.org; Wed, 24 Aug 2005 07:41:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1E7tdb-00022H-Rl for emacs-devel@gnu.org; Wed, 24 Aug 2005 07:41:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1E7tdb-0001lN-0u for emacs-devel@gnu.org; Wed, 24 Aug 2005 07:41:47 -0400 Original-Received: from [209.226.175.188] (helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1E7tWU-0004MJ-QT; Wed, 24 Aug 2005 07:34:27 -0400 Original-Received: from alfajor ([67.71.119.141]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050824113322.TJBB27245.tomts25-srv.bellnexxia.net@alfajor>; Wed, 24 Aug 2005 07:33:22 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id 28CF4D731C; Wed, 24 Aug 2005 07:33:17 -0400 (EDT) Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Tue, 23 Aug 2005 20:10:00 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42387 Archived-At: > * emacs-lisp/easy-mmode.el (define-minor-mode): Don't automatically add > a :require to the defcustom. > I don't remember the precise details of the bug that that change fixed, > but it certainly fixed one. So your change is definitely not correct. > Please do not install it. The bug it fixed is the one where customizing font-lock-mode would add in your .emacs a custom setting that requires font-core which of course breaks when the same .emacs is read with some older Emacs. AFAIK Michael's problem should be fixed by Luc Van Eycken 's patch. I thought it had been installed already, but it seems like that's not the case. I'll do that now. Stefan