From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: allocate_string_data memory corruption Date: Thu, 26 Jan 2006 13:40:35 -0500 Message-ID: <87r76usumg.fsf-monnier+emacs@gnu.org> References: <87vewha2zl.fsf@stupidchicken.com> <87zmlq6w62.fsf-monnier+emacs@gnu.org> <874q3v6a65.fsf-monnier+emacs@gnu.org> <873bjbahq6.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1138303647 4183 80.91.229.2 (26 Jan 2006 19:27:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 26 Jan 2006 19:27:27 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 26 20:27:23 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F2Cld-0004Xu-O7 for ged-emacs-devel@m.gmane.org; Thu, 26 Jan 2006 20:26:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F2CoR-0003nK-9h for ged-emacs-devel@m.gmane.org; Thu, 26 Jan 2006 14:29:43 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F2C6J-0003uM-Og for emacs-devel@gnu.org; Thu, 26 Jan 2006 13:44:07 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F2C6H-0003tA-L9 for emacs-devel@gnu.org; Thu, 26 Jan 2006 13:44:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F2C5p-0003kJ-W0 for emacs-devel@gnu.org; Thu, 26 Jan 2006 13:43:40 -0500 Original-Received: from [209.226.175.188] (helo=tomts25-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1F2C3N-0000se-Uu; Thu, 26 Jan 2006 13:41:06 -0500 Original-Received: from alfajor ([70.49.80.203]) by tomts25-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20060126184035.GYYG25777.tomts25-srv.bellnexxia.net@alfajor>; Thu, 26 Jan 2006 13:40:35 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 52DE2D72D5; Thu, 26 Jan 2006 13:40:35 -0500 (EST) Original-To: rms@gnu.org In-Reply-To: (Richard M. Stallman's message of "Thu, 26 Jan 2006 12:46:46 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49592 Archived-At: > For the sake of the release, how about just moving the threatened > portion of allocate_vectorlike into the BLOCK_INPUT section that's > already present in the function? > Ok. There's no BLOCK_INPUT used in allocate_vectorlike unless DOUG_LEA_MALLOC is defined. But admittedly, allocate_vectorlike is very slow anyway (at least on platforms where we use conservative stack scanning, i.e. in 99% of the cases) so adding a BLOCK_INPUT there isn't a problem. > But can all the known problems be fixed this way? At the cost of adding BLOCK_INPUT for each allocation function? Sure, but I'd rather not do that. Stefan