From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: [gmane.emacs.sources] dir-locals.el Date: Tue, 20 Jun 2006 08:36:08 -0400 Message-ID: <87r71kt35z.fsf@stupidchicken.com> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1150806995 6250 80.91.229.2 (20 Jun 2006 12:36:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 20 Jun 2006 12:36:35 +0000 (UTC) Cc: Dave Love , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 20 14:36:33 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FsfT3-0002Df-Vw for ged-emacs-devel@m.gmane.org; Tue, 20 Jun 2006 14:36:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FsfT3-0005uL-E4 for ged-emacs-devel@m.gmane.org; Tue, 20 Jun 2006 08:36:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FsfSo-0005uA-Kd for emacs-devel@gnu.org; Tue, 20 Jun 2006 08:36:14 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FsfSn-0005tz-Lw for emacs-devel@gnu.org; Tue, 20 Jun 2006 08:36:13 -0400 Original-Received: from [18.72.1.2] (helo=south-station-annex.mit.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FsfdK-0006Na-3U; Tue, 20 Jun 2006 08:47:06 -0400 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id k5KCaA4h008290; Tue, 20 Jun 2006 08:36:11 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id k5KCaAV2002502; Tue, 20 Jun 2006 08:36:10 -0400 (EDT) Original-Received: from cyd (SYDNEYPACIFIC-FOUR-EIGHTY-EIGHT.MIT.EDU [18.95.6.233]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id k5KCa70L025557; Tue, 20 Jun 2006 08:36:07 -0400 (EDT) Original-Received: from cyd by cyd with local (Exim 3.36 #1 (Debian)) id 1FsfSi-0000bE-00; Tue, 20 Jun 2006 08:36:08 -0400 Original-To: storm@cua.dk (Kim F. Storm) In-Reply-To: (Kim F. Storm's message of "Tue, 20 Jun 2006 13:13:54 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-Spam-Score: 1.47 X-Scanned-By: MIMEDefang 2.42 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:56033 Archived-At: storm@cua.dk (Kim F. Storm) writes: > Before, hack-local-variables-hook was run unconditionally at the end > of hack-local-variables, but now it is only run if the file has local > variables. > > Is that change intentional or just an oversight? It is an oversight. This little patch should fix it; I'll install it over the next few days. *** emacs/lisp/files.el.~1.844.~ 2006-06-12 23:38:23.000000000 -0400 --- emacs/lisp/files.el 2006-06-20 08:34:27.000000000 -0400 *************** *** 2635,2642 **** (hack-local-variables-confirm result unsafe-vars risky-vars)) (dolist (elt result) ! (hack-one-local-variable (car elt) (cdr elt)))))) ! (run-hooks 'hack-local-variables-hook)))))) (defun safe-local-variable-p (sym val) "Non-nil if SYM is safe as a file-local variable with value VAL. --- 2635,2642 ---- (hack-local-variables-confirm result unsafe-vars risky-vars)) (dolist (elt result) ! (hack-one-local-variable (car elt) (cdr elt))))))) ! (run-hooks 'hack-local-variables-hook))))) (defun safe-local-variable-p (sym val) "Non-nil if SYM is safe as a file-local variable with value VAL.