From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Diane Murray Newsgroups: gmane.emacs.devel Subject: Re: Avoid a redirect loop in url-http Date: Fri, 13 Apr 2007 14:36:23 +0200 Message-ID: <87r6qoa1tk.fsf@x3y2z1.net> References: <87hcrp0vzp.fsf@x3y2z1.net> <87tzvmrzs7.fsf@stupidchicken.com> <87slb5u2tt.fsf@x3y2z1.net> <87fy757fvg.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1176467615 14942 80.91.229.12 (13 Apr 2007 12:33:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 Apr 2007 12:33:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 13 14:33:34 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HcKy4-0005qF-Cs for ged-emacs-devel@m.gmane.org; Fri, 13 Apr 2007 14:33:32 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HcL2K-0004Xo-QB for ged-emacs-devel@m.gmane.org; Fri, 13 Apr 2007 08:37:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HcL2H-0004Xj-Mc for emacs-devel@gnu.org; Fri, 13 Apr 2007 08:37:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HcL2G-0004XR-8W for emacs-devel@gnu.org; Fri, 13 Apr 2007 08:37:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HcL2G-0004XO-6F for emacs-devel@gnu.org; Fri, 13 Apr 2007 08:37:52 -0400 Original-Received: from mailout04.sul.t-online.com ([194.25.134.18]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HcKxy-0001PG-Cu for emacs-devel@gnu.org; Fri, 13 Apr 2007 08:33:26 -0400 Original-Received: from fwd35.aul.t-online.de by mailout04.sul.t-online.com with smtp id 1HcKxu-00047a-00; Fri, 13 Apr 2007 14:33:22 +0200 Original-Received: from spargel (SgCaBeZbwerDroFvH38VeZzxSleAY-O4NY4P1YScP3lJgRAYRN7FZy@[84.189.217.220]) by fwd35.sul.t-online.de with esmtp id 1HcKxg-1gXsqO0; Fri, 13 Apr 2007 14:33:08 +0200 In-reply-to: <87fy757fvg.fsf@stupidchicken.com> (cyd@stupidchicken.com) X-ID: SgCaBeZbwerDroFvH38VeZzxSleAY-O4NY4P1YScP3lJgRAYRN7FZy@t-dialin.net X-TOI-MSGID: c76d60fd-239b-4f9f-9226-206c88b8903d X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69388 Archived-At: On Thu, 12 Apr 2007 Chong Yidong wrote: > How about this patch? Yes, it works. Thank you. I recommend sending a `url-http-debug' message when the maximum number of redirections has been reached. I'd also mention in the doc string of `url-max-redirections' that it's probably not the best idea to allow unlimited redirections. A couple questions: Should the test be made after adding the new redirect-uri to `url-callback-arguments'? Could the error that's set be a little more specific - perhaps something like 'redirect-limit instead of 'http? -- Diane Murray