all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Diane Murray <disumu@x3y2z1.net>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: Avoid a redirect loop in url-http
Date: Fri, 13 Apr 2007 14:36:23 +0200	[thread overview]
Message-ID: <87r6qoa1tk.fsf@x3y2z1.net> (raw)
In-Reply-To: <87fy757fvg.fsf@stupidchicken.com> (cyd@stupidchicken.com)

On Thu, 12 Apr 2007 Chong Yidong <cyd@stupidchicken.com> wrote:

> How about this patch?

Yes, it works.  Thank you.

I recommend sending a `url-http-debug' message when the maximum number
of redirections has been reached.  I'd also mention in the doc string
of `url-max-redirections' that it's probably not the best idea to
allow unlimited redirections.

A couple questions:
Should the test be made after adding the new redirect-uri to
`url-callback-arguments'?  Could the error that's set be a little more
specific - perhaps something like 'redirect-limit instead of 'http?

--
Diane Murray

  reply	other threads:[~2007-04-13 12:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-10  3:05 Avoid a redirect loop in url-http Diane Murray
2007-04-12  4:18 ` Chong Yidong
2007-04-12 10:25   ` Kim F. Storm
2007-04-12 13:42   ` Diane Murray
2007-04-12 15:48     ` Chong Yidong
2007-04-13 12:36       ` Diane Murray [this message]
2007-04-13 15:00         ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r6qoa1tk.fsf@x3y2z1.net \
    --to=disumu@x3y2z1.net \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.