all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: kill-compilation failing when there are several compilation buffers
Date: Wed, 01 Aug 2007 22:43:20 +0300	[thread overview]
Message-ID: <87r6mndorr.fsf@jurta.org> (raw)
In-Reply-To: <jwvodhr2kc7.fsf-monnier+gnu.emacs.bug@gnu.org> (Stefan Monnier's message of "Wed\, 01 Aug 2007 14\:23\:25 -0400")

>> !   (if (and (compilation-buffer-internal-p (current-buffer))
>> ! 	   (not avoid-current))
>> !       (current-buffer)
>> !     (next-error-find-buffer avoid-current 'compilation-buffer-internal-p)))
>   
> Curiously, next-error-find-buffer only checks current-buffer as its
> 3rd choice.  This function either needs to be changed to try the current
> buffer as its first choice, or it needs a clear comment explaining why.
>
> It looks like this was changed by:
>
>    revision 1.655
>    date: 2004-09-01 13:05:59 -0400;  author: jurta;  state: Exp;  lines: +45 -45;
>    * simple.el (next-error-find-buffer): Move the rule
>    "if current buffer is a next-error capable buffer" after the
>    rule "if next-error-last-buffer is set to a live buffer".
>    Simplify to test all rules in one `or'.
>    (next-error): Doc fix.
>
> where it is not explained.  Juri, do you remember what was the motivation
> for this change?

This change was based on the conclusion of the very long discussion started
from http://lists.gnu.org/archive/html/emacs-devel/2004-05/msg00476.html

Any change in current rules may break test cases mentioned on that thread.

-- 
Juri Linkov
http://www.jurta.org/emacs/

  parent reply	other threads:[~2007-08-01 19:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-31 18:25 kill-compilation failing when there are several compilation buffers Edward Welbourne
2007-08-01  5:38 ` Richard Stallman
2007-08-01  7:44   ` Edward Welbourne
2007-08-07  9:13   ` Edward Welbourne
2007-08-07  9:30   ` Edward Welbourne
2007-08-07 20:12     ` Richard Stallman
     [not found] ` <mailman.4188.1185946583.32220.bug-gnu-emacs@gnu.org>
     [not found]   ` <jwvodhr2kc7.fsf-monnier+gnu.emacs.bug@gnu.org>
2007-08-01 19:43     ` Juri Linkov [this message]
2007-08-02 15:36       ` Stefan Monnier
2007-08-02 16:17       ` next-error-find-buffer (was: kill-compilation failing when there are several compilation buffers) Stefan Monnier
2007-08-02 20:45         ` next-error-find-buffer Ted Zlatanov
2007-08-03  3:38         ` next-error-find-buffer (was: kill-compilation failing when there are several compilation buffers) Richard Stallman
2007-08-03 18:19         ` next-error-find-buffer Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r6mndorr.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.