all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* remove dabbrev--scanning-message?
@ 2007-07-23  5:16 Sean O'Rourke
  2007-07-23  8:37 ` Thien-Thi Nguyen
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Sean O'Rourke @ 2007-07-23  5:16 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

When `dabbrev-expand' is invoked with many buffers and it fails
to find an expansion, there is an annoying forced pause while it
scans every buffer and emits uninteresting progress messages.  If
these messages are removed, a failed expansion is nearly
instantaneous, so I don't see any benefit to having progress
messages.  Patch attached.

/s

2007-07-22  Sean O'Rourke <sorourke@cs.ucsd.edu>

	* dabbrev.el (dabbrev--scanning-message): removed.
        (dabbrev--find-expansion): remove calls.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1408 bytes --]

Index: dabbrev.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/dabbrev.el,v
retrieving revision 1.85
diff -u -r1.85 dabbrev.el
--- dabbrev.el	16 May 2007 13:13:20 -0000	1.85
+++ dabbrev.el	23 Jul 2007 05:07:50 -0000
@@ -711,10 +711,6 @@
 	(setq all-expansions (cons expansion all-expansions))))
     all-expansions))
 
-(defun dabbrev--scanning-message ()
-  (unless (window-minibuffer-p (selected-window))
-    (message "Scanning `%s'" (buffer-name (current-buffer)))))
-
 (defun dabbrev--ignore-buffer-p (buffer)
   "Return non-nil if BUFFER should be ignored by dabbrev."
   (let ((bn (buffer-name buffer)))
@@ -740,8 +736,7 @@
     ;; If we were scanning something other than the current buffer,
     ;; continue scanning there.
     (when dabbrev--last-buffer
-      (set-buffer dabbrev--last-buffer)
-      (dabbrev--scanning-message))
+      (set-buffer dabbrev--last-buffer))
     (or
      ;; ------------------------------------------
      ;; Look backward in current buffer.
@@ -781,7 +776,6 @@
 	 (while (and (not expansion) dabbrev--friend-buffer-list)
 	   (setq dabbrev--last-buffer (pop dabbrev--friend-buffer-list))
 	   (set-buffer dabbrev--last-buffer)
-	   (dabbrev--scanning-message)
 	   (setq dabbrev--last-expansion-location (point-min))
 	   (setq expansion (dabbrev--try-find abbrev nil 1 ignore-case)))
 	 expansion)))))

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2007-08-23  9:38 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-23  5:16 remove dabbrev--scanning-message? Sean O'Rourke
2007-07-23  8:37 ` Thien-Thi Nguyen
2007-07-23 13:40   ` Sean O'Rourke
2007-07-23 19:19     ` Eli Zaretskii
2007-07-23 19:18 ` Eli Zaretskii
2007-07-24 16:46   ` Richard Stallman
2007-07-24 17:16     ` Sean O'Rourke
2007-07-23 22:30 ` Richard Stallman
2007-07-23 22:58   ` Sean O'Rourke
2007-07-23 23:18     ` Thien-Thi Nguyen
2007-07-24  0:40       ` Sean O'Rourke
2007-07-24 22:16         ` Richard Stallman
2007-08-22  1:35         ` Thien-Thi Nguyen
2007-08-22  1:49           ` Sean O'Rourke
2007-08-22 21:27           ` Richard Stallman
2007-08-23  9:38             ` Thien-Thi Nguyen
2007-08-22 19:49         ` Thien-Thi Nguyen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.