From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: michael@cadilhac.name (=?iso-8859-1?Q?Micha=EBl?= Cadilhac) Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/net/browse-url.el: Bugfixes regarding Elinks support (improved resend) Date: Wed, 19 Sep 2007 13:32:43 +0200 Organization: Epita/LRDE Message-ID: <87r6kuki04.fsf@cadilhac.name> References: <20070914105143.GA5686@saeurebad.de> <20070917124843.GA26157@saeurebad.de> <87zlzjj7ta.fsf@cadilhac.name> <20070919111302.GB13654@saeurebad.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0603268376==" X-Trace: sea.gmane.org 1190201358 15966 80.91.229.12 (19 Sep 2007 11:29:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 19 Sep 2007 11:29:18 +0000 (UTC) To: Emacs development discussions Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 19 13:29:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IXxk3-0004S2-J3 for ged-emacs-devel@m.gmane.org; Wed, 19 Sep 2007 13:29:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IXxk2-0002lD-31 for ged-emacs-devel@m.gmane.org; Wed, 19 Sep 2007 07:29:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IXxjy-0002kU-A9 for emacs-devel@gnu.org; Wed, 19 Sep 2007 07:29:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IXxjw-0002jt-87 for emacs-devel@gnu.org; Wed, 19 Sep 2007 07:29:09 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IXxjw-0002jp-4M for emacs-devel@gnu.org; Wed, 19 Sep 2007 07:29:08 -0400 Original-Received: from ext.lri.fr ([129.175.15.4]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IXxjv-0002UQ-EC for emacs-devel@gnu.org; Wed, 19 Sep 2007 07:29:07 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by ext.lri.fr (Postfix) with ESMTP id 23692A4707 for ; Wed, 19 Sep 2007 13:29:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at lri.fr Original-Received: from ext.lri.fr ([127.0.0.1]) by localhost (ext.lri.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u-4Xtju1RnGe for ; Wed, 19 Sep 2007 13:29:06 +0200 (CEST) Original-Received: from smtp.lri.fr (vhost3-23 [129.175.3.23]) by ext.lri.fr (Postfix) with ESMTP id 0EBE1A46FE for ; Wed, 19 Sep 2007 13:29:06 +0200 (CEST) Original-Received: from lri4-154 (pc4-154 [129.175.4.154]) by smtp.lri.fr (Postfix) with ESMTP id 036C3E0502 for ; Wed, 19 Sep 2007 13:29:05 +0200 (CEST) X-Website: http://michael.cadilhac.name Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEVWPh+Tai+5r5YKBAEU CQQzGAtiq7gjAAACR0lEQVQ4jW2UzW7lIAyFzVW8BzTZX5DmCZLuU2H2pMXv/ypzbK7aSh2kRCRf /HNsE0q7Sg+RQ7JFKaqtrRNAl5AIIKe6D5DBqgbmUAe5hBI1wIRFAHjeM0RKtZi7XVVEpb0BSNfA IddChChT5DildSLWOWhY5IEItMnncZgFcUAc/5jjwCMsDosRNdfKPDTFEdVBW8C+RebDb4N5Orio RhM1+11IJyx0ng2+LryFHBMPDQDYHrY6IfGuU3ouiXTQNE8LIJDKOWpNxERTFrggQwRPd7USUsTW fJ0XbR3bdj5KgBYy4SACpxDeUYEUAzLmtJ1iIrD2gczPq8Qomjhsh/RjGIgKIO8p7NITjwlx7WID nsnQe5NeuTvoBpi8LX6vLLOh5icjOHqBypgnuSp7M+RE1agbQKHQr5E2z1WObhYW4gMqeGQL7joM jCf2DxSk5ApADSYHfFF4igNfJZL1z0GKP0FN02s4XiDXr7V5P94W6I9v8MfBOQDmfwAaVYt+x8Da v4DJvX8BAdin3Knm5yMZYAO4ABDkDniZLLfi4P40gP1F0TPGZOu0CGwA1lcowxwlGy6A9705mD0V jHCxwVZT/hYdRJVUGZNlx6l7ScQBTluof6Wj6bsPYlvpwoTvXFD9gHPn2TZPF3ntI2ecxVrW5MrV XiCie5EeNa7BlWu/HNSkprDUva163PHxAv5jyGV7gVzyAghSKOTnat85UIYFICXbD2NV9rRiv0BS tKQsg6OHH4A15F1WW+UHKHHa32h6aPnAm3/pUcWp+WYnTQAAAABJRU5ErkJggg== In-Reply-To: <20070919111302.GB13654@saeurebad.de> (Johannes Weiner's message of "Wed, 19 Sep 2007 13:13:02 +0200") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-Detected-Kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:79299 Archived-At: --===============0603268376== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Johannes Weiner writes: > On Wed, Sep 19, 2007 at 11:58:09AM +0200, Micha=EBl Cadilhac wrote: >> Johannes Weiner writes: >> > The current browse-url-elinks function is broken! >> > >> > Patch including ChangeLog entry attached. >>=20 >> Can you please send me this patch updated against the current CVS >> repository? > > Yes. Patch attached. Thank you, perfect, installed! (Except that a period should be followed by two spaces when it ends a sentence, and that one entry of the ChangeLog didn't use the imperative.) > PS: You renamed the first argument in browse-url-url-encode-chars to > `text' but the function body still refers to `url'. It works thanks > to dynamic scoping, but I think this is not what you intended (since > `text' is never used at all in the body). Yek, dash it! You're utterly right, thanks for the report. =2D-=20 | Micha=EBl `Micha' Cadilhac | Libertude, = | | http://michael.cadilhac.name | =C9galitude, = | | JID/MSN: | Fraternitude. = | `---- michael.cadilhac@gmail.com | -- =C0 peu pr=E8s S.R. = - --' --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.6 (GNU/Linux) iD8DBQFG8QjeUJhDmOfFA3URAgIEAJ97K968JJGee9v3bTj+G5nXuLM/lgCfYtHR PbV01YGWO7ZNJPfeILtsVx4= =4Qm+ -----END PGP SIGNATURE----- --=-=-=-- --===============0603268376== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --===============0603268376==--