From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Hansen Newsgroups: gmane.emacs.devel Subject: [patch] sort eshell glob matches Date: Mon, 05 Nov 2007 04:08:00 +0100 Organization: disorganized Message-ID: <87r6j5v17z.fsf@localhorst.mine.nu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1194232128 26983 80.91.229.12 (5 Nov 2007 03:08:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2007 03:08:48 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 05 04:08:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IosKX-0001kH-Bx for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 04:08:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IosKM-0002Jn-Gk for ged-emacs-devel@m.gmane.org; Sun, 04 Nov 2007 22:08:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IosKI-0002Jh-ON for emacs-devel@gnu.org; Sun, 04 Nov 2007 22:08:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IosKH-0002IA-AU for emacs-devel@gnu.org; Sun, 04 Nov 2007 22:08:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IosKH-0002I4-2p for emacs-devel@gnu.org; Sun, 04 Nov 2007 22:08:33 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IosKG-0005Q1-Ob for emacs-devel@gnu.org; Sun, 04 Nov 2007 22:08:32 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IosKB-0007i8-Pr for emacs-devel@gnu.org; Mon, 05 Nov 2007 03:08:27 +0000 Original-Received: from e178036028.adsl.alicedsl.de ([85.178.36.28]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Nov 2007 03:08:27 +0000 Original-Received: from david.hansen by e178036028.adsl.alicedsl.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Nov 2007 03:08:27 +0000 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 44 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: e178036028.adsl.alicedsl.de Mail-Copies-To: nobody User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) Cancel-Lock: sha1:JFODp6rWCV6DDzVx6w9pm/8CQDU= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82537 Archived-At: --=-=-= Hello, I'm using this patch now for several months w/o problems. I was a bit annoyed that `ogg123 *' played the songs in 'random' and not alphabetical order like w/ bash globing. I can make it customizable if anyone sees a need for it. David --=-=-= Content-Type: text/x-patch Content-Disposition: inline Index: em-glob.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/em-glob.el,v retrieving revision 1.22 diff -c -r1.22 em-glob.el *** em-glob.el 26 Jul 2007 05:26:53 -0000 1.22 --- em-glob.el 5 Nov 2007 03:02:32 -0000 *************** *** 258,264 **** (eshell-glob-entries (file-name-as-directory ".") paths)) (if message-shown (message nil))) ! (or (and matches (nreverse matches)) (if eshell-error-if-no-glob (error "No matches found: %s" glob) glob)))) --- 258,264 ---- (eshell-glob-entries (file-name-as-directory ".") paths)) (if message-shown (message nil))) ! (or (and matches (sort matches #'string<)) (if eshell-error-if-no-glob (error "No matches found: %s" glob) glob)))) Diffs between working revision and workfile end here. --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--