From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: breadcrumbs for Info . . . . . . Date: Sun, 15 Jun 2008 21:18:34 +0300 Organization: JURTA Message-ID: <87r6aysi66.fsf@jurta.org> References: <009d01c8cb55$13d53e20$0200a8c0@us.oracle.com> <87fxrkltma.fsf@jurta.org> <00ae01c8cb71$c26aeef0$0200a8c0@us.oracle.com> <873ankqou6.fsf@jurta.org> <00d901c8cbc9$7df36fb0$0200a8c0@us.oracle.com> <87tzfzk331.fsf@jurta.org> <00a501c8ccdd$93328720$c2b22382@us.oracle.com> <002401c8cd1f$98631650$0200a8c0@us.oracle.com> <004a01c8cd67$b2f7a9c0$0200a8c0@us.oracle.com> <87ve0b5zol.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1213554233 7157 80.91.229.12 (15 Jun 2008 18:23:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Jun 2008 18:23:53 +0000 (UTC) Cc: Drew Adams , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 15 20:24:36 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K7wu3-0005SN-WE for ged-emacs-devel@m.gmane.org; Sun, 15 Jun 2008 20:24:36 +0200 Original-Received: from localhost ([127.0.0.1]:58486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7wtF-0005JX-Iq for ged-emacs-devel@m.gmane.org; Sun, 15 Jun 2008 14:23:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K7wt9-0005IE-Bo for emacs-devel@gnu.org; Sun, 15 Jun 2008 14:23:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K7wt8-0005I0-07 for emacs-devel@gnu.org; Sun, 15 Jun 2008 14:23:39 -0400 Original-Received: from [199.232.76.173] (port=54097 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K7wt7-0005Hx-RI for emacs-devel@gnu.org; Sun, 15 Jun 2008 14:23:37 -0400 Original-Received: from anti-4.kiev.sovam.com ([62.64.120.202]:54483) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K7wt7-0003qx-T1 for emacs-devel@gnu.org; Sun, 15 Jun 2008 14:23:38 -0400 Original-Received: from [83.170.232.243] (helo=smtp.svitonline.com) by anti-4.kiev.sovam.com with esmtp (Exim 4.67) (envelope-from ) id 1K7wt4-0007nx-Lw; Sun, 15 Jun 2008 21:23:34 +0300 In-Reply-To: (Stefan Monnier's message of "Sat, 14 Jun 2008 22:04:48 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (x86_64-pc-linux-gnu) X-Scanner-Signature: c2436a487120708c9e0f2b31fdd4cc45 X-DrWeb-checked: yes X-SpamTest-Envelope-From: juri@jurta.org X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Trusted X-SpamTest-Info: Profiles 3134 [June 15 2008] X-SpamTest-Info: {received from trusted relay: common white list} X-SpamTest-Info: {HEADERS: header Content-Type found without required header Content-Transfer-Encoding} X-SpamTest-Method: white ip list X-SpamTest-Rate: 10 X-SpamTest-Status: Trusted X-SpamTest-Status-Extended: trusted X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release X-detected-kernel: by monty-python.gnu.org: FreeBSD 6.x (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99264 Archived-At: >> There is one problem: all breadcrumb links are displayed as visited >> even when there are not. The simplest fix is to let-bind variables >> Info-history and Info-history-list in Info-insert-breadcrumbs. But >> I see Info-find-node is called with `no-going-back'. Maybe code that >> adds a new visited node to Info-history-list should be moved from >> Info-select-node to Info-find-node-2 and be called conditionally >> on no-going-back, but this would be inappropriate semantics for >> Info-history-list. So perhaps let-bind is the best fix. > > Oh, yes, indeed. Info.el's code is terrible in this respect. > Could you try and fix this problem, please? Done. Now there is no need to mess around with the history since Info-insert-breadcrumbs uses the cached parent-children structure shared with the TOC node. -- Juri Linkov http://www.jurta.org/emacs/