From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Memory leak in keyboard variables? Date: Sat, 20 Dec 2008 15:41:51 -0500 Message-ID: <87r642tw8g.fsf@cyd.mit.edu> References: <87d4fzh0qc.fsf@cyd.mit.edu> <87y6ymiw93.fsf@cyd.mit.edu> <8763lqcuju.fsf@stupidchicken.com> <87bpvccirc.fsf@cyd.mit.edu> <877i5z1kka.fsf@xemacs.org> <87ocz7pqbj.fsf@cyd.mit.edu> <494D10A1.1000905@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1229805728 21755 80.91.229.12 (20 Dec 2008 20:42:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Dec 2008 20:42:08 +0000 (UTC) Cc: "Stephen J. Turnbull" , Markus Triska , emacs-devel@gnu.org To: Jan =?utf-8?Q?Dj=C3=A4rv?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 20 21:43:13 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LE8fE-0002cG-GH for ged-emacs-devel@m.gmane.org; Sat, 20 Dec 2008 21:43:08 +0100 Original-Received: from localhost ([127.0.0.1]:41449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LE8e2-0006Cz-0x for ged-emacs-devel@m.gmane.org; Sat, 20 Dec 2008 15:41:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LE8dy-0006Cs-A5 for emacs-devel@gnu.org; Sat, 20 Dec 2008 15:41:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LE8dx-0006Cg-Ez for emacs-devel@gnu.org; Sat, 20 Dec 2008 15:41:49 -0500 Original-Received: from [199.232.76.173] (port=43652 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LE8dx-0006Cd-A1 for emacs-devel@gnu.org; Sat, 20 Dec 2008 15:41:49 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:45193) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LE8dx-00074S-1R for emacs-devel@gnu.org; Sat, 20 Dec 2008 15:41:49 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 2CBBC57E175; Sat, 20 Dec 2008 15:41:52 -0500 (EST) In-Reply-To: <494D10A1.1000905@swipnet.se> ("Jan =?utf-8?Q?Dj=C3=A4rv=22's?= message of "Sat, 20 Dec 2008 16:34:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107139 Archived-At: Jan Dj=C3=A4rv writes: > From what I see, the frames aren't garabge collected, and then neither > is the menu bar items in f->menu_bar_vector, which isn't used for the > non-toolkit case. > > The frame is at least referenced from recent-keys, and maybe one more > place which I haven't found. > > Setting f->menu_bar_vector to Qnil when deleting the frame improves > the situation quite a bit, I'm not sure if it totally eliminates the > leak. I've checked in that change. I see. Thanks for finding the problem.