From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Please try Pmail Date: Sun, 18 Jan 2009 09:47:46 -0500 Message-ID: <87r6303c31.fsf@cyd.mit.edu> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1232290065 18279 80.91.229.12 (18 Jan 2009 14:47:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Jan 2009 14:47:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 18 15:48:58 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LOYxM-0007T0-IN for ged-emacs-devel@m.gmane.org; Sun, 18 Jan 2009 15:48:56 +0100 Original-Received: from localhost ([127.0.0.1]:58228 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOYw3-0003bs-AJ for ged-emacs-devel@m.gmane.org; Sun, 18 Jan 2009 09:47:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LOYvx-0003YZ-RV for emacs-devel@gnu.org; Sun, 18 Jan 2009 09:47:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LOYvw-0003WJ-7M for emacs-devel@gnu.org; Sun, 18 Jan 2009 09:47:29 -0500 Original-Received: from [199.232.76.173] (port=50801 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LOYvw-0003W8-4b for emacs-devel@gnu.org; Sun, 18 Jan 2009 09:47:28 -0500 Original-Received: from cyd.mit.edu ([18.115.2.24]:54510) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LOYvt-0007wy-F3; Sun, 18 Jan 2009 09:47:25 -0500 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 6563857E197; Sun, 18 Jan 2009 09:47:46 -0500 (EST) In-Reply-To: (Richard M. Stallman's message of "Sat, 17 Jan 2009 22:43:09 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107959 Archived-At: Richard M Stallman writes: > Pmail is basically working now. I have used it for all my mail > reading for weeks, and I have also gone through all the code making > sure all the commands work. So please try it. > > I see no reason not to include it in the next release. > It should not cause any delay. Thanks. First, the swapping code in pmail should be tweaked to use write-region-annotate, like in Stefan's 2008-12-30 change to tar-mode.el. Also, I've been wondering about the following code in pmail.el, which is used to perform babyl-to-mbox conversion. It uses temp-files to transfer the data. Would this lead to a security hole via symlink attack? Could someone suggest a solution? (Maybe a simple fix is to make the temp files in .emacs.d?) (defun pmail-convert-babyl-to-mbox () "Convert the mail file from Babyl version 5 to mbox. This function also reinitializes local variables used by Pmail." (let ((old-file (make-temp-file "pmail")) (new-file (make-temp-file "pmail"))) (unwind-protect (progn (kill-all-local-variables) (write-region (point-min) (point-max) old-file) (unrmail old-file new-file) (message "Replacing BABYL format with mbox format...") (let ((inhibit-read-only t)) (erase-buffer) (insert-file-contents-literally new-file) ...