From: Torsten Bronger <bronger@physik.rwth-aachen.de>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 2157@emacsbugs.donarmstrong.com
Subject: bug#2157: 23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files
Date: Wed, 04 Feb 2009 18:09:30 +0100 [thread overview]
Message-ID: <87r62egmd1.fsf@physik.rwth-aachen.de> (raw)
In-Reply-To: 200902041548.n14FmA2I015985@rodan.ics.uci.edu
Hallöchen!
Dan Nicolaescu writes:
> [...]
>
> It looks like the lightweight checkout contains a
> .bzr/branch/location file that is not present in a normal one. So
> that could be used to differentiate between the two, like here:
>
> --- vc-bzr.el.~1.74.~ Wed Feb 4 05:54:29 2009
> +++ vc-bzr.el Wed Feb 4 07:43:07 2009
> @@ -327,7 +327,12 @@
> (lastrev-file (expand-file-name vc-bzr-admin-lastrev rootdir)))
> ;; This looks at internal files to avoid forking a bzr process.
> ;; May break if they change their format.
> - (if (file-exists-p branch-format-file)
> + (if (and
> + (file-exists-p branch-format-file)
> + (not (file-exists-p
> + (expand-file-name
> + (concat vc-bzr-admin-dirname
> + "/branch/location") rootdir))))
> (with-temp-buffer
> (insert-file-contents branch-format-file)
> (goto-char (point-min))
This probably works, however, even better is to check whether the
"location" starts with "file://" and then look there. Maybe one can
just call the function recursively just with another "file"
parameter (must "file" exist actually?). If "location" doesn't
start with "file://", do the fallback.
The Bazaar documentation explicitly says that lightweight checkouts
should be done only locally. For example, you can use them to
switch efficiently between locally stored branches. Therefore, one
can expect "file://" in most cases indeed.
I use to have many files open (40+), and when I start Emacs, I can
see a significant CPU usage of bzr processes now, thus my concern.
Tschö,
Torsten.
--
Torsten Bronger, aquisgrana, europa vetus
Jabber ID: torsten.bronger@jabber.rwth-aachen.de
next prev parent reply other threads:[~2009-02-04 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200903231626.n2NGQlXn010786@godzilla.ics.uci.edu>
2009-02-02 10:04 ` bug#2157: 23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files Torsten Bronger
2009-02-02 20:05 ` Dan Nicolaescu
2009-02-02 20:37 ` Torsten Bronger
2009-02-02 22:37 ` Dan Nicolaescu
2009-02-03 7:35 ` Torsten Bronger
2009-02-04 7:43 ` Dan Nicolaescu
2009-02-04 8:31 ` Torsten Bronger
2009-02-04 15:48 ` Dan Nicolaescu
2009-02-04 17:09 ` Torsten Bronger [this message]
2009-02-03 7:48 ` Torsten Bronger
2009-03-23 16:35 ` bug#2157: marked as done (23.0.90; bzr support: vc-diff doesn't work with prefix argument on unchanged files) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r62egmd1.fsf@physik.rwth-aachen.de \
--to=bronger@physik.rwth-aachen.de \
--cc=2157@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.