From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Remove useless if-before-free and if-before-xfree tests Date: Mon, 29 Jun 2009 09:52:09 +0200 Message-ID: <87r5x3lbo6.fsf@kfs-lx.rd.rdm> References: <87d48nvc6k.fsf@meyering.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1246262035 754 80.91.229.12 (29 Jun 2009 07:53:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jun 2009 07:53:55 +0000 (UTC) Cc: Emacs development discussions To: Jim Meyering Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 29 09:53:48 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MLBgR-0007Qa-DL for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2009 09:53:47 +0200 Original-Received: from localhost ([127.0.0.1]:32784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLBgQ-0006Zv-VD for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2009 03:53:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLBfC-0004w4-O8 for emacs-devel@gnu.org; Mon, 29 Jun 2009 03:52:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLBfA-0004v5-P9 for emacs-devel@gnu.org; Mon, 29 Jun 2009 03:52:30 -0400 Original-Received: from [199.232.76.173] (port=51962 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLBfA-0004v1-Lb for emacs-devel@gnu.org; Mon, 29 Jun 2009 03:52:28 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:16489) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MLBfA-0002Ka-3E for emacs-devel@gnu.org; Mon, 29 Jun 2009 03:52:28 -0400 Original-Received: from mail1-hoer.fullrate.dk ([90.185.1.42] helo=smtp.fullrate.dk) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLBf2-0006Mp-9L for emacs-devel@gnu.org; Mon, 29 Jun 2009 03:52:20 -0400 Original-Received: from kfs-lx.rd.rdm.cua.dk (3008ds4-amb.0.fullrate.dk [90.184.173.162]) by smtp.fullrate.dk (Postfix) with SMTP id CA2E09D290; Mon, 29 Jun 2009 09:52:09 +0200 (CEST) In-Reply-To: <87d48nvc6k.fsf@meyering.net> (Jim Meyering's message of "Mon, 29 Jun 2009 07:30:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) X-Detected-Operating-System: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111804 Archived-At: Jim Meyering writes: > I removed a bunch of these last year. > Since then, a few have snuck back in, so here's another round. > I've just committed the following two change sets: I haven't looked specifically at the changes, but a test before xfree may not be useless performance-wise if the normal case is "ptr is NULL". -- Kim F. Storm http://www.cua.dk