* Better subjects, bodies for commit diff emails?
@ 2010-01-13 19:29 Karl Fogel
2010-01-13 19:38 ` Dan Nicolaescu
2010-01-13 20:09 ` Glenn Morris
0 siblings, 2 replies; 8+ messages in thread
From: Karl Fogel @ 2010-01-13 19:29 UTC (permalink / raw)
To: emacs-devel
Our commit diff emails currently have subject lines like this:
"[Emacs-diffs] /srv/bzr/emacs/trunk r99318: Fix gc bug in terminal allocation."
They would be better like this, I think:
"[Emacs-diffs] r99318: Fix gc bug in terminal allocation."
The "/srv/bzr/emacs/trunk" is pretty much wasted space. Do we even send
commit emails for other branches? I don't know, but if we don't, then
there's no need to take up space saying the branch; and if we do, then
we could just say "trunk" or "foo" without the "/srv/bzr/emacs/" prefix.
Meanwhile, in the message body, adding some vertical whitepace would
make improve readability. I'll mark my suggestions below with "###":
revno: 99318
committer: Chong Yidong <cyd@stupidchicken.com>
branch nick: trunk
timestamp: Wed 2010-01-13 13:35:36 -0500
message:
Fix gc bug in terminal allocation.
* xterm.c (x_term_init): Avoid garbage-collecting the new terminal
during call to vendor-specific-keysyms (Bug#5365).
### How about a blank line here? Currently there is not one. ###
modified:
src/ChangeLog
src/xterm.c
### And how about a blank line here? Currently there is not one. ###
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog 2010-01-13 04:42:45 +0000
+++ b/src/ChangeLog 2010-01-13 18:35:36 +0000
### After this point, there are blank lines between hunks, so all good ##
I don't know what would be involved in fixing these problems. I presume
a Savannah support request for at least the first, and either a Savannah
SR and/or a patch to some Bazaar tool for the latter.
If people agree that these would be good, I (might :-) ) take a look.
Thoughts?
-Karl
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-13 19:29 Better subjects, bodies for commit diff emails? Karl Fogel
@ 2010-01-13 19:38 ` Dan Nicolaescu
2010-01-13 21:25 ` Karl Fogel
2010-01-13 21:26 ` Glenn Morris
2010-01-13 20:09 ` Glenn Morris
1 sibling, 2 replies; 8+ messages in thread
From: Dan Nicolaescu @ 2010-01-13 19:38 UTC (permalink / raw)
To: Karl Fogel; +Cc: emacs-devel
Karl Fogel <kfogel@red-bean.com> writes:
> Our commit diff emails currently have subject lines like this:
>
> "[Emacs-diffs] /srv/bzr/emacs/trunk r99318: Fix gc bug in terminal allocation."
>
> They would be better like this, I think:
>
> "[Emacs-diffs] r99318: Fix gc bug in terminal allocation."
>
> The "/srv/bzr/emacs/trunk" is pretty much wasted space. Do we even send
So is [Emacs-diffs]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-13 19:29 Better subjects, bodies for commit diff emails? Karl Fogel
2010-01-13 19:38 ` Dan Nicolaescu
@ 2010-01-13 20:09 ` Glenn Morris
2010-01-13 20:32 ` Glenn Morris
1 sibling, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2010-01-13 20:09 UTC (permalink / raw)
To: Karl Fogel; +Cc: emacs-devel
Karl Fogel wrote:
> Do we even send commit emails for other branches?
Not usually, but sometimes. Eg for a branch like EMACS_23_1_RC:
http://lists.gnu.org/archive/html/emacs-devel/2009-06/msg00389.html
Here you can set the subject format that CVS used:
http://lists.gnu.org/archive/html/emacs-diffs/2009-07/index.html
Trunk was implicit, [EMACS_23_1_RC] was placed at the end when
appropriate.
For the purposes of Gnus scoring, I found it more useful when the
subject line contained the changed files. But this doesn't scale to
multi-file commits anyway.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-13 20:09 ` Glenn Morris
@ 2010-01-13 20:32 ` Glenn Morris
0 siblings, 0 replies; 8+ messages in thread
From: Glenn Morris @ 2010-01-13 20:32 UTC (permalink / raw)
To: Karl Fogel; +Cc: emacs-devel
Glenn Morris wrote:
> Here you can set the subject format that CVS used:
^^^
see
> http://lists.gnu.org/archive/html/emacs-diffs/2009-07/index.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-13 19:38 ` Dan Nicolaescu
@ 2010-01-13 21:25 ` Karl Fogel
2010-01-13 21:26 ` Glenn Morris
1 sibling, 0 replies; 8+ messages in thread
From: Karl Fogel @ 2010-01-13 21:25 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: emacs-devel
Dan Nicolaescu <dann@ics.uci.edu> writes:
>Karl Fogel <kfogel@red-bean.com> writes:
> > Our commit diff emails currently have subject lines like this:
> >
> > "[Emacs-diffs] /srv/bzr/emacs/trunk r99318: Fix gc bug in terminal allocation."
> >
> > They would be better like this, I think:
> >
> > "[Emacs-diffs] r99318: Fix gc bug in terminal allocation."
> >
> > The "/srv/bzr/emacs/trunk" is pretty much wasted space. Do we even send
>
>So is [Emacs-diffs]
Yes -- I'd *love* to get rid of that too, but I'm so accustomed to
losing that battle on other forums that I didn't even bother to suggest
it here. But if we have rough consensus that the "[Emacs-diffs]" is
unnecessary, let's ditch it!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-13 19:38 ` Dan Nicolaescu
2010-01-13 21:25 ` Karl Fogel
@ 2010-01-13 21:26 ` Glenn Morris
2010-01-14 18:35 ` Eli Zaretskii
1 sibling, 1 reply; 8+ messages in thread
From: Glenn Morris @ 2010-01-13 21:26 UTC (permalink / raw)
To: Dan Nicolaescu; +Cc: Karl Fogel, Eli Zaretskii, emacs-devel
Dan Nicolaescu wrote:
> So is [Emacs-diffs]
I think that's a Mailman option that the list owner (Eli) could unset.
(I read it via Gmane, which seems to strip that prefix. I never missed it.)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-13 21:26 ` Glenn Morris
@ 2010-01-14 18:35 ` Eli Zaretskii
2010-01-14 19:23 ` Karl Fogel
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2010-01-14 18:35 UTC (permalink / raw)
To: Glenn Morris; +Cc: kfogel, dann, emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Cc: Karl Fogel <kfogel@red-bean.com>, emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 13 Jan 2010 16:26:18 -0500
>
> Dan Nicolaescu wrote:
>
> > So is [Emacs-diffs]
>
> I think that's a Mailman option
That's true.
> that the list owner (Eli) could unset.
I will do that if there's consensus to get rid of it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Better subjects, bodies for commit diff emails?
2010-01-14 18:35 ` Eli Zaretskii
@ 2010-01-14 19:23 ` Karl Fogel
0 siblings, 0 replies; 8+ messages in thread
From: Karl Fogel @ 2010-01-14 19:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: dann, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Glenn Morris <rgm@gnu.org>
>> Cc: Karl Fogel <kfogel@red-bean.com>, emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
>> Date: Wed, 13 Jan 2010 16:26:18 -0500
>>
>> Dan Nicolaescu wrote:
>>
>> > So is [Emacs-diffs]
>>
>> I think that's a Mailman option
>
>That's true.
>
>> that the list owner (Eli) could unset.
>
>I will do that if there's consensus to get rid of it.
Well, +1 here...
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-01-14 19:23 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-13 19:29 Better subjects, bodies for commit diff emails? Karl Fogel
2010-01-13 19:38 ` Dan Nicolaescu
2010-01-13 21:25 ` Karl Fogel
2010-01-13 21:26 ` Glenn Morris
2010-01-14 18:35 ` Eli Zaretskii
2010-01-14 19:23 ` Karl Fogel
2010-01-13 20:09 ` Glenn Morris
2010-01-13 20:32 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.