all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Eric Schulte" <schulte.eric@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: feature request: save LaTeX as title for ltxpng html images
Date: Wed, 31 Mar 2010 10:24:43 -0600	[thread overview]
Message-ID: <87r5n0792s.fsf@gmail.com> (raw)
In-Reply-To: <CC3D0DBC-7BCE-481D-9504-73674CA0D0F7@gmail.com> (Carsten Dominik's message of "Tue, 30 Mar 2010 09:37:18 +0200")

Thanks, I've made your suggested change and applied the patch. -- Eric

Carsten Dominik <carsten.dominik@gmail.com> writes:

> Hi Eric, looks good to me, please go ahead and apply this patch.
>
> I would not have expected that this is such a compact change.
> The only improvement I can see would be to use org-add-props to
> put the properties on the link before inserting it and in this
> way shave off a let form.
>
> Thanks!
>
> - Carsten
> On Mar 30, 2010, at 8:26 AM, Eric Schulte wrote:
>
>> Hi,
>>
>> The attached patch places the latex source into alt html image tags as
>> described below.  I think it should be safe, in that I remove all "s
>> from inside of the alt string.
>>
>> Thanks for the implementation advice -- Eric
>>
>> diff --git a/lisp/org-html.el b/lisp/org-html.el
>> index b8925e7..2246daf 100644
>> --- a/lisp/org-html.el
>> +++ b/lisp/org-html.el
>> @@ -1529,7 +1529,8 @@ lang=\"%s\" xml:lang=\"%s\">
>>   "Create image tag with source and attributes."
>>   (save-match-data
>>     (if (string-match "^ltxpng/" src)
>> -	(format "<img src=\"%s\"/>" src)
>> +	(format "<img src=\"%s\" alt=\"%s\"/>"
>> +                src (org-find-text-property-in-string 'org-latex-
>> src src))
>>       (let* ((caption (org-find-text-property-in-string 'org-caption
>> src))
>> 	     (attr (org-find-text-property-in-string 'org-attributes src))
>> 	     (label (org-find-text-property-in-string 'org-label src)))
>> 	Modified lisp/org.el
>> diff --git a/lisp/org.el b/lisp/org.el
>> index e30c49a..480e9f1 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -15183,7 +15183,12 @@ Some of the options can be changed using
>> the variable
>> 		  (push ov org-latex-fragment-image-overlays)
>> 		  (goto-char end))
>> 	      (delete-region beg end)
>> -	      (insert link))))))))
>> +              (let ((link-beg (point))
>> +                    (link-end (progn (insert link) (point))))
>> +                (add-text-properties
>> +                 link-beg link-end
>> +                 (list 'org-latex-src
>> +                       (replace-regexp-in-string "\"" ""
>> txt)))))))))))
>>
>> ;; This function borrows from Ganesh Swami's latex2png.el
>> (defun org-create-formula-image (string tofile options buffer)
>>
>>
>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>
>>> On Mar 26, 2010, at 4:01 PM, Eric Schulte wrote:
>>>
>>>> Hi,
>>>>
>>>> HTML <img> tags allow both alternate text (rendered when the image
>>>> can't
>>>> be rendered), as well as titles which show as tooltips on hover.  I
>>>> wonder if it would be difficult to place the text latex used in
>>>> generating an image into these two fields.  If not then I at least
>>>> would
>>>> find it useful.
>>>
>>> It is not trivial, but not too hard either.
>>>
>>> It is not trivial because Org first produces the images and inserts
>>> org-style links. Later, in a second step, these links are replaced
>>> (formatted for HTML).
>>> One way to solve this is that `org-format-latex' will add this
>>> information
>>> as text properties to the link.  Then later, when the HTML formatting
>>> is done,
>>> the text property could be retrieved and converted into the
>>> attributes
>>> you are mentioning.
>>>
>>> You have worked on org-format-latex before, I think this should be
>>> relatively easy for you.
>>>
>>> - Carsten
>
> - Carsten

      reply	other threads:[~2010-03-31 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26 15:01 feature request: save LaTeX as title for ltxpng html images Eric Schulte
2010-03-26 20:42 ` Carsten Dominik
2010-03-30  6:26   ` Eric Schulte
2010-03-30  7:37     ` Carsten Dominik
2010-03-31 16:24       ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5n0792s.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.