[Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[Achim Gratz]

The function org-link-escape escapes the '+' in file+sys and file+emacs
link types and creates some problems for export by doing so.  Only the
path component of a link URI should be escaped, but not the type part.


Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Re: [Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[David Maus]

[-- Attachment #1.1: Type: text/plain, Size: 578 bytes --]

Achim Gratz wrote:
>The function org-link-escape escapes the '+' in file+sys and file+emacs
>link types and creates some problems for export by doing so.  Only the
>path component of a link URI should be escaped, but not the type part.

Does this still happen und could you provide an example?

I've tried

,----[ *x* ]
|
| * Foo
|
| [[file+emacs:/tmp/foo.txt][foo]]
`----

And export to HTML works fine:

,----
| <p>
| <a href="file:///tmp/foo.txt">foo</a>
| </p>
`----

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[Achim Gratz]

David Maus <dmaus@ictsoc.de> writes:
> Achim Gratz wrote:
>>The function org-link-escape escapes the '+' in file+sys and file+emacs
>>link types and creates some problems for export by doing so.  Only the
>>path component of a link URI should be escaped, but not the type part.
>
> Does this still happen und could you provide an example?

Yes it does.  The first link has been entered literally, the second
using C-c C-l.  The first link will turn into the second form as soon as
I use C-c C-l on it and can only be reverted in "literal" mode.

[[file+emacs:~/org/notes.org][My Notes]]
[[file%2Bemacs:~/org/notes.org][My Notes]]

The export to HTML delivers:

<a href="file:///obscured/org/notes.html">My Notes</a>
<a href="#file+emacs:~/org/notes.org">My Notes</a>

Org-mode version 7.01trans (release_7.01h.557.g8de43)
GNU Emacs 23.1.1 


Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables

Re: Re: [Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[David Maus]

[-- Attachment #1.1: Type: text/plain, Size: 970 bytes --]

Achim Gratz wrote:
>David Maus <dmaus@ictsoc.de> writes:
>> Achim Gratz wrote:
>>>The function org-link-escape escapes the '+' in file+sys and file+emacs
>>>link types and creates some problems for export by doing so.  Only the
>>>path component of a link URI should be escaped, but not the type part.
>>
>> Does this still happen und could you provide an example?

>Yes it does.  The first link has been entered literally, the second
>using C-c C-l.  The first link will turn into the second form as soon as
>I use C-c C-l on it and can only be reverted in "literal" mode.

>[[file+emacs:~/org/notes.org][My Notes]]
>[[file%2Bemacs:~/org/notes.org][My Notes]]

>The export to HTML delivers:

><a href="file:///obscured/org/notes.html">My Notes</a>
><a href="#file+emacs:~/org/notes.org">My Notes</a>

Thanks for clarification.  It should be fixed now in master.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[Achim Gratz]

David Maus <dmaus@ictsoc.de> writes:
> Thanks for clarification.  It should be fixed now in master.

You only wish... it doesn't escape the link type now, but adds a
colon on each call of C-c C-l:

[[file+emacs:~/org/notes.org][My Notes]]
[[file+emacs::~/org/notes.org][My Notes]]
[[file+emacs:::~/org/notes.org][My Notes]]

This messes up the HTML export even more:

<a href="file:///home/gratz/org/notes.html">My Notes</a>
<a href=":~/org/notes.html">My Notes</a>
<a href="">My Notes</a>

Interesting, isn't it? :-)


Sorry for being a troublemaker today,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

Re: Re: [Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[David Maus]

[-- Attachment #1.1: Type: text/plain, Size: 346 bytes --]

Achim Gratz wrote:
>David Maus <dmaus@ictsoc.de> writes:
>> Thanks for clarification.  It should be fixed now in master.

>You only wish... it doesn't escape the link type now, but adds a
>colon on each call of C-c C-l:

Ooops, fixed now.

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: [Bug] lisp/org.el (org-link-escape) escapes the type part of a link

[Achim Gratz]

David Maus <dmaus@ictsoc.de> writes:
> Ooops, fixed now.

Confirmed.


Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Samples for the Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#BlofeldSamplesExtra