* [RFC] Review uuid.el -- library for UUID generation
@ 2010-11-09 4:07 Kan-Ru Chen
2010-11-13 16:56 ` Chong Yidong
0 siblings, 1 reply; 3+ messages in thread
From: Kan-Ru Chen @ 2010-11-09 4:07 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
Hello list,
I recently started a new library project, uuid-el, for generating UUIDs
for RSS feeds, or other places where UUID are used. Since this is my
first serious elisp program--a relatively simple one though--I'd like to
take the chance to improve the code and to learn some conventions.
So it would be appreciated if someone could kindly review my uuid.el ;-)
- Kanru
[-- Attachment #2: library for UUID generation --]
[-- Type: application/emacs-lisp, Size: 8720 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] Review uuid.el -- library for UUID generation
2010-11-09 4:07 [RFC] Review uuid.el -- library for UUID generation Kan-Ru Chen
@ 2010-11-13 16:56 ` Chong Yidong
2010-11-14 7:08 ` Kan-Ru Chen
0 siblings, 1 reply; 3+ messages in thread
From: Chong Yidong @ 2010-11-13 16:56 UTC (permalink / raw)
To: Kan-Ru Chen; +Cc: emacs-devel
Kan-Ru Chen <kanru@kanru.info> writes:
> I recently started a new library project, uuid-el, for generating UUIDs
> for RSS feeds, or other places where UUID are used. Since this is my
> first serious elisp program--a relatively simple one though--I'd like to
> take the chance to improve the code and to learn some conventions.
Pretty good for a first elisp program. I don't see any convention
violations. Just one minor nitpick:
(let ((address (uuid-get-ieee-address)))
(mapconcat (lambda (var) (format "%02x" var))
address "")
))
Try not to leave close parentheses on lines by themselves; this tends to
annoy Lisp programmers.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] Review uuid.el -- library for UUID generation
2010-11-13 16:56 ` Chong Yidong
@ 2010-11-14 7:08 ` Kan-Ru Chen
0 siblings, 0 replies; 3+ messages in thread
From: Kan-Ru Chen @ 2010-11-14 7:08 UTC (permalink / raw)
To: emacs-devel
Chong Yidong <cyd@stupidchicken.com> writes:
> Kan-Ru Chen <kanru@kanru.info> writes:
>
>> I recently started a new library project, uuid-el, for generating UUIDs
>> for RSS feeds, or other places where UUID are used. Since this is my
>> first serious elisp program--a relatively simple one though--I'd like to
>> take the chance to improve the code and to learn some conventions.
>
> Pretty good for a first elisp program. I don't see any convention
> violations. Just one minor nitpick:
>
> (let ((address (uuid-get-ieee-address)))
> (mapconcat (lambda (var) (format "%02x" var))
> address "")
> ))
>
> Try not to leave close parentheses on lines by themselves; this tends to
> annoy Lisp programmers.
Thank you.
I've put the updated version on github.
Newer version uses `calc' package for bignum arithmetic, which should
work on more platform. The only concern I have now is that the
`network-interface-list' and `network-interface-info' aren't widely
implemented or implemented correctly. For example, only Linux version
of `network-interface-info' will return non-nil HWADDR.
--
A badly written book is only a blunder. A bad translation of a good
book is a crime.
-- Gilbert Highet
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-14 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-09 4:07 [RFC] Review uuid.el -- library for UUID generation Kan-Ru Chen
2010-11-13 16:56 ` Chong Yidong
2010-11-14 7:08 ` Kan-Ru Chen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.