From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Jim Meyering <jim@meyering.net>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] make-docfile: don't corrupt heap for an invalid .elc
	file
Date: Sun, 30 Jan 2011 10:21:21 +0100
Message-ID: <87r5bu7nn2.fsf@meyering.net>
References: <87wrlsqj3m.fsf@meyering.net>
NNTP-Posting-Host: lo.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: dough.gmane.org 1296379300 23610 80.91.229.12 (30 Jan 2011 09:21:40 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Sun, 30 Jan 2011 09:21:40 +0000 (UTC)
To: Emacs development discussions <emacs-devel@gnu.org>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 30 10:21:35 2011
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1PjTTS-0006Ho-Pl
	for ged-emacs-devel@m.gmane.org; Sun, 30 Jan 2011 10:21:34 +0100
Original-Received: from localhost ([127.0.0.1]:48248 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1PjTTS-00073E-9s
	for ged-emacs-devel@m.gmane.org; Sun, 30 Jan 2011 04:21:34 -0500
Original-Received: from [140.186.70.92] (port=52467 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PjTTK-000738-Q7
	for emacs-devel@gnu.org; Sun, 30 Jan 2011 04:21:27 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1PjTTI-00016v-H6
	for emacs-devel@gnu.org; Sun, 30 Jan 2011 04:21:26 -0500
Original-Received: from mx.meyering.net ([82.230.74.64]:33973)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jim@meyering.net>) id 1PjTTI-00016h-BG
	for emacs-devel@gnu.org; Sun, 30 Jan 2011 04:21:24 -0500
Original-Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000)
	id 5859D602DF; Sun, 30 Jan 2011 10:21:21 +0100 (CET)
In-Reply-To: <87wrlsqj3m.fsf@meyering.net> (Jim Meyering's message of "Wed, 26
	Jan 2011 07:23:09 +0100")
Original-Lines: 9
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3)
X-Received-From: 82.230.74.64
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:135230
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/135230>

Jim Meyering wrote:
> Subject: [PATCH] make-docfile: don't corrupt heap for an invalid .elc file
>
> "printf '#@1' > in.elc; ./make-docfile in.elc" would write a '\0'
> one byte before the just-malloc'd saved_string buffer.
> * make-docfile.c (scan_lisp_file): Diagnose an invalid dynamic
> doc string length.  Also fix an always-false while-loop test.

I committed this to master.