From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Installing `struct buffer' patch Date: Mon, 14 Feb 2011 11:42:56 -0500 Message-ID: <87r5ba7ejz.fsf@stupidchicken.com> References: <4D47DFD4.1040108@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297701801 24336 80.91.229.12 (14 Feb 2011 16:43:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 14 Feb 2011 16:43:21 +0000 (UTC) Cc: emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 14 17:43:16 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp1W7-0004YJ-Os for ged-emacs-devel@m.gmane.org; Mon, 14 Feb 2011 17:43:16 +0100 Original-Received: from localhost ([127.0.0.1]:41222 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp1W7-00044Z-2t for ged-emacs-devel@m.gmane.org; Mon, 14 Feb 2011 11:43:15 -0500 Original-Received: from [140.186.70.92] (port=34095 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pp1W0-00042m-Sp for emacs-devel@gnu.org; Mon, 14 Feb 2011 11:43:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pp1Vz-0001rV-8s for emacs-devel@gnu.org; Mon, 14 Feb 2011 11:43:08 -0500 Original-Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]:40631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pp1Vz-0001r1-37 for emacs-devel@gnu.org; Mon, 14 Feb 2011 11:43:07 -0500 Original-Received: from furball (dhcp128036225012.central.yale.edu [128.36.225.12]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1EGh2tk002318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 14 Feb 2011 11:43:02 -0500 Original-Received: by furball (Postfix, from userid 1000) id C92D71605B1; Mon, 14 Feb 2011 11:42:56 -0500 (EST) In-Reply-To: (Tom Tromey's message of "Sun, 13 Feb 2011 13:26:34 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135999 Archived-At: Tom Tromey writes: > It may break some builds that I cannot test. However, in all cases, the > fix is simple. The patch renames the fields of `struct buffer', so when > you see an error arising from `something->field', you can simply change > that to read `B_ (something, field)'. Please do not change any code to > use `BUFFER_INTERNAL_FIELD'. Hmm, I just realized that the B_ macro doesn't make for very understandable code. The name is too cryptic. What do you think about replacing B_ with lots of individual macros, like BUF_UNDO_LIST, BUF_NAME, etc.? This might be ugly in buffer.h, but the rest of the code would be more understandable.