From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#9081: 24.0.50; crash in X Date: Wed, 17 Aug 2011 17:38:42 -0400 Message-ID: <87r54jwwf1.fsf@stupidchicken.com> References: <87wrefemiu.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1313617157 28659 80.91.229.12 (17 Aug 2011 21:39:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 17 Aug 2011 21:39:17 +0000 (UTC) To: 9081@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 17 23:39:13 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QtnpR-00038e-LD for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Aug 2011 23:39:13 +0200 Original-Received: from localhost ([::1]:34219 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtnpR-0007UU-6h for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Aug 2011 17:39:13 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:52092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtnpM-0007Kr-Kt for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2011 17:39:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QtnpL-0002u0-1m for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2011 17:39:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QtnpK-0002tw-W8 for bug-gnu-emacs@gnu.org; Wed, 17 Aug 2011 17:39:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QtnrC-00089E-2E; Wed, 17 Aug 2011 17:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2011 21:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9081 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9081-submit@debbugs.gnu.org id=B9081.131361724231275 (code B ref 9081); Wed, 17 Aug 2011 21:41:02 +0000 Original-Received: (at 9081) by debbugs.gnu.org; 17 Aug 2011 21:40:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qtnqr-00088N-0t for submit@debbugs.gnu.org; Wed, 17 Aug 2011 17:40:41 -0400 Original-Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qtnqo-00088F-5J for 9081@debbugs.gnu.org; Wed, 17 Aug 2011 17:40:38 -0400 Original-Received: from furball (dhcp-128-36-225-145.central.yale.edu [128.36.225.145]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7HLcg0A016199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for <9081@debbugs.gnu.org>; Wed, 17 Aug 2011 17:38:42 -0400 In-Reply-To: <87wrefemiu.fsf@stupidchicken.com> (Chong Yidong's message of "Sun, 14 Aug 2011 17:00:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 17 Aug 2011 17:41:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50115 Archived-At: Chong Yidong writes: > /* Since Fsignal will close off all calls to x_catch_errors, > we will get the wrong results if some are not closed now. */ > #if HAVE_X_WINDOWS > if (x_catching_errors ()) > abort (); > #endif > > Anyone have a clue about the rationale of the above code? It was > inserted by RMS on 2006-03-11, but I don't see anything in the > emacs-devel or bug-gnu-emacs archives discussing this. Note that there > is no corresponding check in internal_lisp_condition_case. Note also > that x_reply_selection_request has a record_unwind_protect to uncatch X > errors. I removed those lines; let us see if that causes any trouble.