From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Kazuhiro Ito <kzhr@d1.dion.ne.jp>, 9311@debbugs.gnu.org
Subject: bug#9311: 23.3.50; Can't load some byte-compiled files on Windows
Date: Tue, 30 Aug 2011 17:26:38 +0200 [thread overview]
Message-ID: <87r542or81.fsf@gmx.de> (raw)
In-Reply-To: <jwvei037yvi.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 30 Aug 2011 10:33:55 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> In the discussion of bug#5303 there was the proposal to remove the
>> volume letter from `tramp-completion-file-name-regexp'. This was
>> postponed, because we were in pretest phase.
>> But we haven't done it after that release.
>> Shall we try it now? Somehow, we are still before a pretest ...
>
> Coulf you post a sample patch, together with a discussion of the impact?
Sometimes (I cannot reproduce it persistently), there are situations
that `expand-file-name' prefixes a remote file name by a volume
letter. Happens on win32 only, of course, and confuses Tramp.
In order to let Tramp continue its work, we have accepted remote file
names with a leading volume letter, which are removed by Tramp
then. This worked almost OK, except such cases as discussed in the
current (and earlier) bug reports.
Eli did suggest to remove this hack from Tramp, and to see during the
test where the unexpected volume letter prefix happens. Problems shall
be fixed there.
The following patch does it, in its final version there could be some
additional minor polishing.
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/tramp/lisp/tramp.el.~2.843~ 2011-08-30 17:10:16.058151065 +0200
--- /home/albinus/src/tramp/lisp/tramp.el 2011-08-30 17:07:38.841961797 +0200
***************
*** 861,873 ****
Also see `tramp-file-name-structure'.")
;;;###autoload
! (defconst tramp-root-regexp
! (if (memq system-type '(cygwin windows-nt))
! "\\`\\([a-zA-Z]:\\)?/"
! "\\`/")
! "Beginning of an incomplete Tramp file name.
! Usually, it is just \"\\\\`/\". On W32 systems, there might be a
! volume letter, which will be removed by `tramp-drop-volume-letter'.")
;;;###autoload
(defconst tramp-completion-file-name-regexp-unified
--- 861,868 ----
Also see `tramp-file-name-structure'.")
;;;###autoload
! (defconst tramp-root-regexp "\\`/"
! "Beginning of an incomplete Tramp file name.")
;;;###autoload
(defconst tramp-completion-file-name-regexp-unified
***************
*** 1503,1509 ****
but the remote system is Unix, this introduces a superfluous drive
letter into the file name. This function removes it."
(save-match-data
! (if (string-match tramp-root-regexp name)
(replace-match "/" nil t name)
name)))
--- 1498,1504 ----
but the remote system is Unix, this introduces a superfluous drive
letter into the file name. This function removes it."
(save-match-data
! (if (string-match "\\`[a-zA-Z]:/" name)
(replace-match "/" nil t name)
name)))
--8<---------------cut here---------------end--------------->8---
> Stefan
Best regards, Michael.
next prev parent reply other threads:[~2011-08-30 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 0:24 bug#9311: 23.3.50; Can't load some byte-compiled files on Windows Kazuhiro Ito
2011-08-17 8:55 ` Eli Zaretskii
2011-08-30 13:45 ` Michael Albinus
2011-08-30 14:33 ` Stefan Monnier
2011-08-30 15:26 ` Michael Albinus [this message]
2011-08-30 16:31 ` Stefan Monnier
2011-08-31 9:56 ` Michael Albinus
2011-08-30 17:54 ` Eli Zaretskii
2011-08-17 12:50 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r542or81.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=9311@debbugs.gnu.org \
--cc=kzhr@d1.dion.ne.jp \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.