From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [patch] `org-pop-to-buffer-same-window' working with Emacs24 Date: Sun, 04 Sep 2011 19:01:45 +0200 Message-ID: <87r53wb5s6.fsf@altern.org> References: <87k49o8eq8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:46546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0G46-0003Mq-9V for emacs-orgmode@gnu.org; Sun, 04 Sep 2011 13:01:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0G45-0001By-Aq for emacs-orgmode@gnu.org; Sun, 04 Sep 2011 13:01:02 -0400 Received: from mail-fx0-f41.google.com ([209.85.161.41]:43351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0G45-0001Bo-3j for emacs-orgmode@gnu.org; Sun, 04 Sep 2011 13:01:01 -0400 Received: by fxg9 with SMTP id 9so3449282fxg.0 for ; Sun, 04 Sep 2011 10:01:00 -0700 (PDT) In-Reply-To: <87k49o8eq8.fsf@gmail.com> (Eric Schulte's message of "Sun, 04 Sep 2011 10:16:47 -0600") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Eric Schulte Cc: Org Mode Hi Eric, Eric Schulte writes: > I assume this change was required due to changes in Emacs24, but I had > to remove an argument to pop-to-buffer-same-window in > org-pop-to-buffer-same-window to fix editing of source code snippets. Yes, I already applied this patch -- see commit 4a8634e1. So the latest Org version should work okay for you. > The patch is attached, although I'm not sure if it would break this > function for all other versions of Emacs. I assume most people using latest Org version from git also uses latest Emacs version... but yes, we might have to improve compatibility in this area. Thanks, -- Bastien