all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#10116: M-x compile no longer completes filenames
@ 2011-11-23  2:08 jidanni
  2011-12-06 22:16 ` Stefan Monnier
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: jidanni @ 2011-11-23  2:08 UTC (permalink / raw)
  To: 10116

As of emacs-snapshot:
  Installed: 1:20111121-1
M-x compile
make -k <TAB>
no longer completes filenames.
Furthermore, more TABs will get you
Error in post-command-hook (completion-in-region--postch): (error IO error reading /var/tmp: Is a directory)
insert-file-contents-literally: IO error reading /var/tmp: Is a directory





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10116: M-x compile no longer completes filenames
  2011-11-23  2:08 bug#10116: M-x compile no longer completes filenames jidanni
@ 2011-12-06 22:16 ` Stefan Monnier
  2011-12-07  0:22 ` jidanni
  2011-12-07  1:40 ` jidanni
  2 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-12-06 22:16 UTC (permalink / raw)
  To: jidanni; +Cc: 10116

> As of emacs-snapshot:
>   Installed: 1:20111121-1
> M-x compile
> make -k <TAB>
> no longer completes filenames.

Indeed, the completion rules for `make' failed to mention that file
names are perfectly valid arguments.  I've just installed the patch
below which should address this problem.

> Furthermore, more TABs will get you
> Error in post-command-hook (completion-in-region--postch): (error IO error
> reading /var/tmp: Is a directory)
> insert-file-contents-literally: IO error reading /var/tmp: Is a directory

I can't reproduce this problem.  Can you give more detailed steps to
reproduce it?


        Stefan


=== modified file 'lisp/pcmpl-gnu.el'
--- lisp/pcmpl-gnu.el	2011-12-02 14:44:19 +0000
+++ lisp/pcmpl-gnu.el	2011-12-06 22:11:15 +0000
@@ -99,7 +99,10 @@
   "Completion for GNU `make'."
   (let ((pcomplete-help "(make)Top"))
     (pcomplete-opt "bmC/def(pcmpl-gnu-makefile-names)hiI/j?kl?no.pqrsStvwW.")
-    (while (pcomplete-here (pcmpl-gnu-make-rule-names) nil 'identity))))
+    (while (pcomplete-here (completion-table-in-turn
+                            (pcmpl-gnu-make-rule-names)
+                            (pcomplete-entries))
+                           nil 'identity))))
 
 (defun pcmpl-gnu-makefile-names ()
   "Return a list of possible makefile names."






^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10116: M-x compile no longer completes filenames
  2011-11-23  2:08 bug#10116: M-x compile no longer completes filenames jidanni
  2011-12-06 22:16 ` Stefan Monnier
@ 2011-12-07  0:22 ` jidanni
  2011-12-07  1:29   ` Stefan Monnier
  2011-12-08 13:20   ` Stefan Monnier
  2011-12-07  1:40 ` jidanni
  2 siblings, 2 replies; 6+ messages in thread
From: jidanni @ 2011-12-07  0:22 UTC (permalink / raw)
  To: monnier; +Cc: 10116

>> Furthermore, more TABs will get you
>> Error in post-command-hook (completion-in-region--postch): (error IO error
>> reading /var/tmp: Is a directory)
>> insert-file-contents-literally: IO error reading /var/tmp: Is a directory

SM> I can't reproduce this problem.  Can you give more detailed steps to
SM> reproduce it?

Easy as cake.
$ set emacs-snapshot
$ apt-cache policy $@
emacs-snapshot:
  Installed: 1:20111206-1 # How can I give you a more exact version ? BUG !
$ mkdir v
$ cd v #no files here
$ emacs -Q -nw -f compile
TAB





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10116: M-x compile no longer completes filenames
  2011-12-07  0:22 ` jidanni
@ 2011-12-07  1:29   ` Stefan Monnier
  2011-12-08 13:20   ` Stefan Monnier
  1 sibling, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-12-07  1:29 UTC (permalink / raw)
  To: jidanni; +Cc: 10116

>>> Furthermore, more TABs will get you
>>> Error in post-command-hook (completion-in-region--postch): (error IO error
>>> reading /var/tmp: Is a directory)
>>> insert-file-contents-literally: IO error reading /var/tmp: Is a directory

SM> I can't reproduce this problem.  Can you give more detailed steps to
SM> reproduce it?

> Easy as cake.
> $ set emacs-snapshot
> $ apt-cache policy $@
> emacs-snapshot:
>   Installed: 1:20111206-1 # How can I give you a more exact version ? BUG !
> $ mkdir v
> $ cd v #no files here
> $ emacs -Q -nw -f compile
> TAB

OK, I can reproduce it now and I have a fix for it.  But I have one
question: you originally said you wanted to complete on filenames, but
this bug shows up when there's no Makefile, in which case you'd first
want to specify a file via -f, right?


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10116: M-x compile no longer completes filenames
  2011-11-23  2:08 bug#10116: M-x compile no longer completes filenames jidanni
  2011-12-06 22:16 ` Stefan Monnier
  2011-12-07  0:22 ` jidanni
@ 2011-12-07  1:40 ` jidanni
  2 siblings, 0 replies; 6+ messages in thread
From: jidanni @ 2011-12-07  1:40 UTC (permalink / raw)
  To: monnier; +Cc: 10116

SM> this bug shows up when there's no Makefile, in which case you'd first
SM> want to specify a file via -f, right?

Yes, tons of possibilities... and I hit TAB by accident and discovered
the bug.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#10116: M-x compile no longer completes filenames
  2011-12-07  0:22 ` jidanni
  2011-12-07  1:29   ` Stefan Monnier
@ 2011-12-08 13:20   ` Stefan Monnier
  1 sibling, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2011-12-08 13:20 UTC (permalink / raw)
  To: jidanni; +Cc: 10116-done

SM> I can't reproduce this problem.  Can you give more detailed steps to
SM> reproduce it?

> Easy as cake.
> $ set emacs-snapshot
> $ apt-cache policy $@
> emacs-snapshot:
>   Installed: 1:20111206-1 # How can I give you a more exact version ? BUG !
> $ mkdir v
> $ cd v #no files here
> $ emacs -Q -nw -f compile
> TAB

OK, thanks, fixed,


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-12-08 13:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-23  2:08 bug#10116: M-x compile no longer completes filenames jidanni
2011-12-06 22:16 ` Stefan Monnier
2011-12-07  0:22 ` jidanni
2011-12-07  1:29   ` Stefan Monnier
2011-12-08 13:20   ` Stefan Monnier
2011-12-07  1:40 ` jidanni

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.