From: Chong Yidong <cyd@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Dmitry Antipov <dmantipov@yandex.ru>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames.
Date: Wed, 08 Aug 2012 11:39:09 +0800 [thread overview]
Message-ID: <87r4rigihu.fsf@gnu.org> (raw)
In-Reply-To: <jwvmx2c1l96.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 03 Aug 2012 03:42:45 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> You can use coccinelle to automatically turn the x->y into an rvalue
> FVAR (x,y) while debugging. And such a script should be kept around and
> run every once in a while to check that new code follows the
> SETFVAR convention.
>
> But I don't want the trunk's code obfuscated just for some temporary
> debugging needs.
Another problem, which I haven't seen mentioned in this thread, is that
when you see C code which does FVAR (x, y) the natural assumption is
that x and y are C variables. So these macros hurt code readability.
The introduction of BVAR also violated this principle, and I'm not eager
to see the problem compounded.
I think FSET/WSET/PSET/PGET/etc should be removed from the trunk, at
least for now. I recommend moving the generational GC work to a branch.
next prev parent reply other threads:[~2012-08-08 3:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SwCK8-0001PC-3m@vcs.savannah.gnu.org>
2012-08-01 10:33 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames Stefan Monnier
2012-08-01 12:04 ` Dmitry Antipov
2012-08-01 14:58 ` Paul Eggert
2012-08-01 16:52 ` Dmitry Antipov
2012-08-01 17:38 ` Tom Tromey
2012-08-01 21:04 ` Paul Eggert
2012-08-02 5:28 ` Stephen J. Turnbull
2012-08-01 15:01 ` Eli Zaretskii
2012-08-01 18:02 ` Dmitry Antipov
2012-08-02 15:28 ` Eli Zaretskii
2012-08-01 23:52 ` Stefan Monnier
2012-08-02 4:12 ` Dmitry Antipov
2012-08-02 5:56 ` Stephen J. Turnbull
2012-08-02 7:47 ` Dmitry Antipov
2012-08-02 9:30 ` Juanma Barranquero
2012-08-02 16:07 ` Eli Zaretskii
2012-08-02 15:45 ` Eli Zaretskii
2012-08-02 21:28 ` Paul Eggert
2012-08-03 6:27 ` Eli Zaretskii
2012-08-03 6:52 ` Paul Eggert
2012-08-02 23:38 ` Richard Stallman
2012-08-02 15:34 ` Eli Zaretskii
2012-08-03 7:42 ` Stefan Monnier
2012-08-03 8:31 ` Dmitry Antipov
2012-08-03 18:58 ` Paul Eggert
2012-08-03 22:52 ` Stefan Monnier
2012-08-04 16:31 ` Paul Eggert
2012-08-05 15:03 ` Dmitry Antipov
2012-08-06 10:54 ` Stefan Monnier
2012-08-06 11:44 ` Dmitry Antipov
2012-08-06 16:31 ` Stefan Monnier
2012-08-06 17:43 ` Stefan Monnier
2012-08-08 7:22 ` Chong Yidong
2012-08-05 14:59 ` Dmitry Antipov
2012-08-05 15:23 ` Paul Eggert
2012-08-05 20:29 ` Miles Bader
2012-08-03 22:50 ` Stefan Monnier
2012-08-03 23:11 ` Wojciech Meyer
2012-08-08 3:39 ` Chong Yidong [this message]
2012-08-08 7:14 ` Dmitry Antipov
2012-08-08 7:46 ` Chong Yidong
2012-08-08 10:18 ` Dmitry Antipov
2012-08-08 12:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4rigihu.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.