bug#13045: 24.2.90; dired-guess-shell-command: default in prompt after colon

bug#13045: 24.2.90; dired-guess-shell-command: default in prompt after colon

[Christopher Schmidt]

    emacs -q
    C-x C-f /tmp RET
    M-x load-library RET dired-x RET
    M-! touch rms.tar RET
    g
    # Move point to rms.tar
    !

The prompt says

    ! on rms.tar: {3 guesses} [tar xvf]

I think it should say

    ! on rms.tar {3 guesses} [tar xvf]:

This is consistent with most other commands that insert the default in
the prompt.

The code that generates the prompt is in dired-guess-shell-command.

I think it is a good idea to add a new magic options to Emacs which
will, if customised, unconditionally add the default value, if there is
one, to the minibuffer prompt.  WDYT?

        Christopher

bug#13045: 24.2.90; dired-guess-shell-command: default in prompt after colon

[Juri Linkov]

> I think it is a good idea to add a new magic options to Emacs which
> will, if customised, unconditionally add the default value, if there is
> one, to the minibuffer prompt.  WDYT?

Indeed a new magic option would be good like proposed in
http://debbugs.gnu.org/12443

This could also display the number of available default values
and the first default, e.g. a customized option:

(defcustom minibuffer-default-prompt-format " (%i defaults, %s)"
 "Default format."
 :type 'string)

Then for your example `dired-guess-shell-command' could display:

    ! on rms.tar (3 defaults, tar xvf):

bug#13045: 24.2.90; dired-guess-shell-command: default in prompt after colon

[Christopher Schmidt]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Christopher Schmidt <christopher@ch.ristopher.com> writes:
>     emacs -q
>     C-x C-f /tmp RET
>     M-x load-library RET dired-x RET
>     M-! touch rms.tar RET
>     g
>     # Move point to rms.tar
>     !
>
> The prompt says
>
>     ! on rms.tar: {3 guesses} [tar xvf]
>
> I think it should say
>
>     ! on rms.tar {3 guesses} [tar xvf]:
>
> This is consistent with most other commands that insert the default in
> the prompt.
>
> The code that generates the prompt is in dired-guess-shell-command.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dired-guess-shell-command.diff --]
[-- Type: text/x-diff, Size: 893 bytes --]

=== modified file 'lisp/dired-x.el'
--- lisp/dired-x.el	2012-09-25 04:13:02 +0000
+++ lisp/dired-x.el	2012-12-06 13:47:11 +0000
@@ -1114,6 +1114,7 @@
     (if (null default)
         ;; Nothing to guess
         (read-shell-command prompt nil 'dired-shell-command-history)
+      (setq prompt (replace-regexp-in-string ": $" " " prompt))
       (if (listp default)
           ;; More than one guess
           (setq default-list default
@@ -1124,7 +1125,7 @@
         ;; Just one guess
         (setq default-list (list default)))
       ;; Put the first guess in the prompt but not in the initial value.
-      (setq prompt (concat prompt (format "[%s] " default)))
+      (setq prompt (concat prompt (format "[%s]: " default)))
       ;; All guesses can be retrieved with M-n
       (setq val (read-shell-command prompt nil
                                     'dired-shell-command-history


[-- Attachment #3: Type: text/plain, Size: 65 bytes --]


Patch for emacs-24 as of right now.  WDYT?

        Christopher

bug#13045: 24.2.90; dired-guess-shell-command: default in prompt after colon

[Juri Linkov]

> === modified file 'lisp/dired-x.el'
> --- lisp/dired-x.el	2012-09-25 04:13:02 +0000
> +++ lisp/dired-x.el	2012-12-06 13:47:11 +0000
> @@ -1114,6 +1114,7 @@
>      (if (null default)
>          ;; Nothing to guess
>          (read-shell-command prompt nil 'dired-shell-command-history)
> +      (setq prompt (replace-regexp-in-string ": $" " " prompt))
>        (if (listp default)
>            ;; More than one guess
>            (setq default-list default
> @@ -1124,7 +1125,7 @@
>          ;; Just one guess
>          (setq default-list (list default)))
>        ;; Put the first guess in the prompt but not in the initial value.
> -      (setq prompt (concat prompt (format "[%s] " default)))
> +      (setq prompt (concat prompt (format "[%s]: " default)))

Thanks, this is a satisfactory short-term solution.  Installed to the trunk.