all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Dani Moncayo <dmoncayo@gmail.com>
Cc: 13480@debbugs.gnu.org
Subject: bug#13480: 24.3.50; `C-w' from Isearch should translate newlines to spaces
Date: Thu, 17 Jan 2013 23:27:49 +0200	[thread overview]
Message-ID: <87r4ljh54a.fsf@mail.jurta.org> (raw)
In-Reply-To: <CAH8Pv0iwpPs-67rnTVK7e9+8E518joTpKCXa=YGOGvdCz1-s5g@mail.gmail.com> (Dani Moncayo's message of "Thu, 17 Jan 2013 21:39:29 +0100")

> So I propose that the command `isearch-yank-word-or-char' (C-w in
> Isearch) DTRT in this case, i.e., when `search-whitespace-regexp' is
> non-nil, translate the <newline> into a simple space when pulling text
> from the buffer into the search string.

It makes sense to translate the <newline> into a simple space
only when `search-whitespace-regexp' contains <newline>
such as e.g. (setq search-whitespace-regexp "\\(\\s-\\|\n\\)+")
Otherwise, the translated space won't match <newline>.
It is possible to do this with the patch below.

But then you might also want to translate the <newline> into a space
in `isearch-yank-line' as well?  And maybe also in `isearch-yank-kill'?

=== modified file 'lisp/isearch.el'
--- lisp/isearch.el	2013-01-16 21:45:20 +0000
+++ lisp/isearch.el	2013-01-17 21:27:35 +0000
@@ -1837,7 +1837,14 @@ (defun isearch-yank-internal (jumpform)
    (save-excursion
      (and (not isearch-forward) isearch-other-end
 	  (goto-char isearch-other-end))
-     (buffer-substring-no-properties (point) (funcall jumpform)))))
+     (if (if isearch-regexp
+	     isearch-regexp-lax-whitespace
+	   isearch-lax-whitespace)
+	 (replace-regexp-in-string
+	  search-whitespace-regexp
+	  " "
+	  (buffer-substring-no-properties (point) (funcall jumpform)) nil t)
+       (buffer-substring-no-properties (point) (funcall jumpform))))))
 
 (defun isearch-yank-char-in-minibuffer (&optional arg)
   "Pull next character from buffer into end of search string in minibuffer."





  reply	other threads:[~2013-01-17 21:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 20:39 bug#13480: 24.3.50; `C-w' from Isearch should translate newlines to spaces Dani Moncayo
2013-01-17 21:27 ` Juri Linkov [this message]
2013-01-17 23:10   ` Dani Moncayo
2013-01-17 23:54     ` Dani Moncayo
2013-01-18 21:59       ` Juri Linkov
2013-01-19  8:05         ` Dani Moncayo
2013-01-19  9:56           ` Dani Moncayo
2013-01-19 10:07             ` Juri Linkov
2013-01-19 10:40               ` Dani Moncayo
2013-01-19 10:57                 ` Juri Linkov
2013-01-19 12:11                   ` Dani Moncayo
2013-01-19 15:45                     ` Drew Adams
2013-01-19 15:43                   ` Drew Adams
2013-01-19 17:20                     ` Stefan Monnier
2013-01-19 23:30                       ` Juri Linkov
2013-01-20  9:41                         ` Dani Moncayo
2013-01-20 12:27                           ` Dani Moncayo
2022-04-22 12:28                         ` Lars Ingebrigtsen
2022-04-24 15:46                           ` Juri Linkov
2022-04-25  7:26                             ` Lars Ingebrigtsen
2013-01-19 15:01             ` Drew Adams
2013-01-19  9:59           ` Juri Linkov
2013-08-03 17:09 ` Dani Moncayo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r4ljh54a.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=13480@debbugs.gnu.org \
    --cc=dmoncayo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.