From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation. Date: Tue, 19 Mar 2013 08:29:34 +0400 Message-ID: <87r4jc57wx.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1363667393 12103 80.91.229.3 (19 Mar 2013 04:29:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Mar 2013 04:29:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 19 05:30:19 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UHoBj-0002Sb-Dr for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2013 05:30:15 +0100 Original-Received: from localhost ([::1]:51687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHoBM-0001Z8-8L for ged-emacs-devel@m.gmane.org; Tue, 19 Mar 2013 00:29:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHoBD-0001Yn-Sn for emacs-devel@gnu.org; Tue, 19 Mar 2013 00:29:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHoB9-0003ce-Kh for emacs-devel@gnu.org; Tue, 19 Mar 2013 00:29:43 -0400 Original-Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]:36541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHoB9-0003br-CI for emacs-devel@gnu.org; Tue, 19 Mar 2013 00:29:39 -0400 Original-Received: by mail-la0-f47.google.com with SMTP id fj20so98441lab.20 for ; Mon, 18 Mar 2013 21:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type:x-antivirus :x-antivirus-status; bh=tG5EV9K/xSIalqMPWsexAvCYu9wQDw8k4t2Onlh0XlM=; b=Ii+BtwC0vym0L38ExEy99ocnIN5ivMkGI2u0bnfR2IXi3GxaAppAxGhZWot6S/P4FY Lrl+bxA3CyToHKky1TkWqzZ3DvEU/8EvW2tup8In8jSJ6YVp7mL+ZFaLsL3sMq6WGvIK 4l2ICI6FKEGSZC2cptNFPByUvHEeadeYvQuc3hFIGox+RDgW6lG5E9EZnWvoP8q8KewZ XqXtXe9c32Bv83z7EAHBoSPcuJuFwZllODFnB0hyeUR5cDF8BvModOVJLCsorJy8s/Nk p37Ezb7vIWkj8Up5Rc9fi3eSwvGaNLPDLIRDa0oI+AHcADkeo26JlTBLnw0/iv8UgzQ1 Lqgw== X-Received: by 10.112.162.65 with SMTP id xy1mr7250309lbb.105.1363667378089; Mon, 18 Mar 2013 21:29:38 -0700 (PDT) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPS id oy10sm10035984lab.8.2013.03.18.21.29.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Mar 2013 21:29:37 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Sun, 17 Mar 2013 21:50:32 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Antivirus: avast! (VPS 130318-0, 18.03.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:157943 Archived-At: Stefan Monnier writes: > ------------------------------------------------------------ > revno: 112071 > committer: Stefan Monnier > branch nick: trunk > timestamp: Sun 2013-03-17 21:50:32 -0400 > message: > * lisp/whitespace.el: Fix double evaluation. > (whitespace-space, whitespace-hspace, whitespace-tab) > (whitespace-newline, whitespace-trailing, whitespace-line) > (whitespace-space-before-tab, whitespace-indentation) > (whitespace-empty, whitespace-space-after-tab): Turn defcustoms into > obsolete defvars. > -(defcustom whitespace-space 'whitespace-space > +(defvar whitespace-space 'whitespace-space > "Symbol face used to visualize SPACE. > - > -Used when `whitespace-style' includes the value `spaces'." > - :type 'face > - :group 'whitespace) > +Used when `whitespace-style' includes the value `spaces'.") > +(make-obsolete-variable 'whitespace-space "use the face instead" "24.4") > - (list whitespace-space-regexp 1 whitespace-space t) > + `( > + ,@(when (memq 'spaces whitespace-active-style) > + ;; Show SPACEs. > + `((,whitespace-space-regexp 1 whitespace-space t) IIUC, this does not only make face vars obsolete, but also makes them have no effect. Was that your intention?