* bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. @ 2013-11-16 11:03 Kenjiro NAKAYAMA 2013-11-21 16:47 ` Ted Zlatanov 2013-11-22 3:26 ` Masatake YAMATO 0 siblings, 2 replies; 9+ messages in thread From: Kenjiro NAKAYAMA @ 2013-11-16 11:03 UTC (permalink / raw To: 15910 After the start of eww, if I try to jump to another URL (by M-x eww again), eww asks to enter the URL entirely again. If eww enters the current URL automatically, it is very useful. And if the current URL is not necessary, it is easy to delete the URL. Signed-off-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> --- lisp/net/eww.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 573715e..d835560 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -106,7 +106,7 @@ "Fetch URL and render the page. If the input doesn't look like an URL or a domain name, the word(s) will be searched for via `eww-search-prefix'." - (interactive "sEnter URL or keywords: ") + (interactive (list (read-string "sEnter URL or keywords: " eww-current-url))) (if (and (= (length (split-string url)) 1) (> (length (split-string url "\\.")) 1)) (progn -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. 2013-11-16 11:03 bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts Kenjiro NAKAYAMA @ 2013-11-21 16:47 ` Ted Zlatanov 2013-11-22 3:26 ` Masatake YAMATO 1 sibling, 0 replies; 9+ messages in thread From: Ted Zlatanov @ 2013-11-21 16:47 UTC (permalink / raw To: Kenjiro NAKAYAMA; +Cc: 15910 On Sat, 16 Nov 2013 20:03:11 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote: KN> After the start of eww, if I try to jump to another URL (by M-x eww again), eww asks to enter the URL entirely again. KN> If eww enters the current URL automatically, it is very useful. KN> And if the current URL is not necessary, it is easy to delete the URL. I like the idea. But I'm not sure it's necessary, since simply `up' or `M-p' will normally bring up the input history. I'll take any opinions... Thanks Ted ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. 2013-11-16 11:03 bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts Kenjiro NAKAYAMA 2013-11-21 16:47 ` Ted Zlatanov @ 2013-11-22 3:26 ` Masatake YAMATO 2013-11-22 16:15 ` Ted Zlatanov 1 sibling, 1 reply; 9+ messages in thread From: Masatake YAMATO @ 2013-11-22 3:26 UTC (permalink / raw To: 15910 eww() takes URL only. So I think eww should have its own history stack. However, if the current page is opened via non-interactive call of emm(), the url for the page will not be stored to history stack. As the result the user cannot retrieve the url via \M-p. So I think both the initial value, which Kenjiro proposed, and emm own history stack are needed in read-string. BTW, I recommend you to put ChangeLog entry to the report when you propose a patch. Masatake YAMATO ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. 2013-11-22 3:26 ` Masatake YAMATO @ 2013-11-22 16:15 ` Ted Zlatanov 2013-11-24 15:15 ` bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened Kenjiro NAKAYAMA 2013-11-24 15:57 ` Kenjiro NAKAYAMA 0 siblings, 2 replies; 9+ messages in thread From: Ted Zlatanov @ 2013-11-22 16:15 UTC (permalink / raw To: Masatake YAMATO; +Cc: 15910 On Fri, 22 Nov 2013 12:26:59 +0900 (JST) Masatake YAMATO <yamato@redhat.com> wrote: MY> eww() takes URL only. So I think eww should have its own MY> history stack. However, if the current page is opened via MY> non-interactive call of emm(), the url for the page will MY> not be stored to history stack. As the result the user cannot MY> retrieve the url via \M-p. Good point. s/emm/eww/. MY> So I think both the initial value, which Kenjiro proposed, and emm own MY> history stack are needed in read-string. Yes. Furthermore, followed links within `eww' should be added to the history stack. That would be valuable. MY> BTW, I recommend you to put ChangeLog entry to the report when MY> you propose a patch. Yes, please :) Ted ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened @ 2013-11-24 15:15 ` Kenjiro NAKAYAMA 2013-11-25 14:54 ` bug#15910: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s Ted Zlatanov 0 siblings, 1 reply; 9+ messages in thread From: Kenjiro NAKAYAMA @ 2013-11-24 15:15 UTC (permalink / raw To: 15967 Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it doesn't save current URL in eww-history. Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. --- lisp/net/eww.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 6f09d86..738136b 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -1065,7 +1065,7 @@ The browser to used is specified by the `shr-external-browser' variable." ;; just let it remain. (ignore-errors (delete-window)) - (eww (plist-get bookmark :url)))) + (eww-browse-url (plist-get bookmark :url)))) (defun eww-next-bookmark () "Go to the next bookmark in the list." -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#15910: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. 2013-11-24 15:15 ` bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened Kenjiro NAKAYAMA @ 2013-11-25 14:54 ` Ted Zlatanov 2013-11-26 11:51 ` bug#15966: " Kenjiro NAKAYAMA 0 siblings, 1 reply; 9+ messages in thread From: Ted Zlatanov @ 2013-11-25 14:54 UTC (permalink / raw To: Kenjiro NAKAYAMA; +Cc: 15965, Kenjiro NAKAYAMA, 15966, 15967, 15910 Thank you for the patches. All of them are OK to go in IMO (and tiny changes). Could you consolidate them in a single patch with a ChangeLog please? It can wait for your eww history stack changes or can be submitted sooner. Thanks Ted On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it KN> doesn't save current URL in eww-history. KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: KN> eww should ask "yes or no" when add current page to bookmarks, since KN> only "b" key to add bookmarks is easy to mistake. KN> (My bookmarklist has amazingly increased.) KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: KN> eww should ask "yes or no" before quitting, since only "q" key to quit is KN> easy to mistake. KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> KN> * net/eww.el (eww-quit): ask confirmation before quitting eww On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote: KN> Thank you for your review, Ted, Masatake. KN> OK, I try to revise the patch to add eww own history stack. KN> And I put ChangeLog entry to my report next time. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. 2013-11-25 14:54 ` bug#15910: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s Ted Zlatanov @ 2013-11-26 11:51 ` Kenjiro NAKAYAMA 2013-11-26 20:10 ` bug#15910: " Ted Zlatanov 0 siblings, 1 reply; 9+ messages in thread From: Kenjiro NAKAYAMA @ 2013-11-26 11:51 UTC (permalink / raw To: Ted Zlatanov Cc: Kenjiro NAKAYAMA, 15966, 15967, 15965, 15910, Kenjiro NAKAYAMA Thanks, Ted. I consolidated the patches, please include the patch if appreciated. Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. (eww-add-bookmark): ask confirmation when add to bookmarks (eww-quit): ask confirmation before quitting eww --- lisp/net/eww.el | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 86e0977..4b8b067 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'." (defun eww-quit () "Exit the Emacs Web Wowser." (interactive) - (setq eww-history nil) - (kill-buffer (current-buffer))) + (if (y-or-n-p "quit eww? ") + (progn + (setq eww-history nil) + (kill-buffer (current-buffer))))) (defun eww-back-url () "Go to the previously displayed page." @@ -964,14 +966,16 @@ The browser to used is specified by the `shr-external-browser' variable." (when (equal eww-current-url (plist-get bookmark :url)) (error "Already bookmarked"))) - (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) - (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) - (push (list :url eww-current-url - :title title - :time (current-time-string)) - eww-bookmarks)) - (eww-write-bookmarks) - (message "Bookmarked %s (%s)" eww-current-url eww-current-title)) + (if (y-or-n-p "add bookmark this page? ") + (progn + (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) + (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) + (push (list :url eww-current-url + :title title + :time (current-time-string)) + eww-bookmarks)) + (eww-write-bookmarks) + (message "Bookmarked %s (%s)" eww-current-url eww-current-title)))) (defun eww-write-bookmarks () (with-temp-file (expand-file-name "eww-bookmarks" user-emacs-directory) @@ -1063,7 +1067,7 @@ The browser to used is specified by the `shr-external-browser' variable." ;; just let it remain. (ignore-errors (delete-window)) - (eww (plist-get bookmark :url)))) + (eww-browse-url (plist-get bookmark :url)))) (defun eww-next-bookmark () "Go to the next bookmark in the list." -- 1.8.3.1 Thanks, Kenjiro Nakayama tzz@lifelogs.com writes: > Thank you for the patches. All of them are OK to go in IMO (and tiny > changes). Could you consolidate them in a single patch with a ChangeLog > please? It can wait for your eww history stack changes or can be > submitted sooner. > > Thanks > Ted > > On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: > > KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it > KN> doesn't save current URL in eww-history. > > KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> > > KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. > > On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: > > KN> eww should ask "yes or no" when add current page to bookmarks, since > KN> only "b" key to add bookmarks is easy to mistake. > KN> (My bookmarklist has amazingly increased.) > > KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> > > KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks > > On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: > > KN> eww should ask "yes or no" before quitting, since only "q" key to quit is > KN> easy to mistake. > > KN> Signed-off-by: Kenjiro NAKAYAMA <knakayam@redhat.com> > > KN> * net/eww.el (eww-quit): ask confirmation before quitting eww > > On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> wrote: > > KN> Thank you for your review, Ted, Masatake. > > KN> OK, I try to revise the patch to add eww own history stack. > KN> And I put ChangeLog entry to my report next time. ^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#15910: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. 2013-11-26 11:51 ` bug#15966: " Kenjiro NAKAYAMA @ 2013-11-26 20:10 ` Ted Zlatanov 0 siblings, 0 replies; 9+ messages in thread From: Ted Zlatanov @ 2013-11-26 20:10 UTC (permalink / raw To: Kenjiro NAKAYAMA Cc: 15967-done, 15965-done, Kenjiro NAKAYAMA, 15966-done, 15910-done On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <knakayam@redhat.com> wrote: KN> I consolidated the patches, please include the patch if appreciated. OK; done. I changed "add bookmark this page?" to "bookmark this page?" but otherwise had no issues. Thanks! Ted ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. 2013-11-22 16:15 ` Ted Zlatanov 2013-11-24 15:15 ` bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened Kenjiro NAKAYAMA @ 2013-11-24 15:57 ` Kenjiro NAKAYAMA 1 sibling, 0 replies; 9+ messages in thread From: Kenjiro NAKAYAMA @ 2013-11-24 15:57 UTC (permalink / raw To: 15910 Thank you for your review, Ted, Masatake. OK, I try to revise the patch to add eww own history stack. And I put ChangeLog entry to my report next time. Kenjiro ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-11-26 20:10 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-16 11:03 bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts Kenjiro NAKAYAMA 2013-11-21 16:47 ` Ted Zlatanov 2013-11-22 3:26 ` Masatake YAMATO 2013-11-22 16:15 ` Ted Zlatanov 2013-11-24 15:15 ` bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened Kenjiro NAKAYAMA 2013-11-25 14:54 ` bug#15910: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s Ted Zlatanov 2013-11-26 11:51 ` bug#15966: " Kenjiro NAKAYAMA 2013-11-26 20:10 ` bug#15910: " Ted Zlatanov 2013-11-24 15:57 ` Kenjiro NAKAYAMA
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.