From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#16198: 24.3.50; [PATCH 1/2] eww: Does not support file upload. Date: Wed, 25 Dec 2013 09:26:05 +0100 Message-ID: <87r491l4ki.fsf@building.gnus.org> References: <87fvpnzx8e.fsf@dhcp-193-97.nrt.redhat.com> <87ha9yzot3.fsf@building.gnus.org> <87ob457due.fsf@dhcp-193-97.nrt.redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387960391 22877 80.91.229.3 (25 Dec 2013 08:33:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Dec 2013 08:33:11 +0000 (UTC) Cc: 16198@debbugs.gnu.org To: Kenjiro NAKAYAMA Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 25 09:33:17 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vvju1-0001gb-2V for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 09:33:17 +0100 Original-Received: from localhost ([::1]:41633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvju0-0003Ey-MZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Dec 2013 03:33:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvjts-0003Ej-Vu for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 03:33:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vvjtm-0002LG-R4 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 03:33:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvjtm-0002LC-OB for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 03:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vvjtl-0002xd-Uz for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 03:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2013 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch Original-Received: via spool by 16198-submit@debbugs.gnu.org id=B16198.138796033811308 (code B ref 16198); Wed, 25 Dec 2013 08:33:01 +0000 Original-Received: (at 16198) by debbugs.gnu.org; 25 Dec 2013 08:32:18 +0000 Original-Received: from localhost ([127.0.0.1]:40521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvjt4-0002wJ-6Y for submit@debbugs.gnu.org; Wed, 25 Dec 2013 03:32:18 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:60685) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvjt1-0002w9-Ny for 16198@debbugs.gnu.org; Wed, 25 Dec 2013 03:32:16 -0500 Original-Received: from 46.67.128.193.tmi.telenormobil.no ([46.67.128.193] helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Vvjsn-0002r2-QR; Wed, 25 Dec 2013 09:32:01 +0100 In-Reply-To: <87ob457due.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Wed, 25 Dec 2013 13:29:29 +0900") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1Vvjsn-0002r2-QR MailScanner-NULL-Check: 1388565122.21037@hjsrvKj9ifUZOAeov45hQA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:82575 Archived-At: Kenjiro NAKAYAMA writes: Looks good. One bit that could perhaps be changed is this: > + "Content-Disposition: form-data; name=\"" (cdr (assoc "name" (cdr data))) "\"; filename=\"" (cdr (assoc "filename" (cdr data))) "\"\r\n" Lines shouldn't be longer than 80 characters, and these file names may perhaps contain the " character, which would make these specs invalid? It's usually best to use `format' with %S in these cases: (setq file "foo\"bar") (insert (concat "name=\"" file "\"")) name="foo"bar" (insert (format "name=%S" file)) name="foo\"bar" -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/