all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
Cc: 16198@debbugs.gnu.org
Subject: bug#16198: 24.3.50; [PATCH 1/2] eww: Does not support file upload.
Date: Wed, 25 Dec 2013 09:26:05 +0100	[thread overview]
Message-ID: <87r491l4ki.fsf@building.gnus.org> (raw)
In-Reply-To: <87ob457due.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Wed, 25 Dec 2013 13:29:29 +0900")

Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:

Looks good.  One bit that could perhaps be changed is this:

> +                            "Content-Disposition: form-data; name=\"" (cdr (assoc "name" (cdr data))) "\"; filename=\"" (cdr (assoc "filename" (cdr data))) "\"\r\n"

Lines shouldn't be longer than 80 characters, and these file names may
perhaps contain the " character, which would make these specs invalid?

It's usually best to use `format' with %S in these cases:

(setq file "foo\"bar")

(insert (concat "name=\"" file "\""))
name="foo"bar"

(insert (format "name=%S" file))
name="foo\"bar"

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/





  reply	other threads:[~2013-12-25  8:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20  9:29 bug#16198: 24.3.50; [PATCH 1/2] eww: Does not support file upload Kenjiro NAKAYAMA
2013-12-21 20:27 ` Ted Zlatanov
2013-12-24  7:32 ` Lars Ingebrigtsen
2013-12-25  4:29   ` Kenjiro NAKAYAMA
2013-12-25  8:26     ` Lars Ingebrigtsen [this message]
2013-12-25 15:09       ` Kenjiro NAKAYAMA
2014-11-10 21:34         ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r491l4ki.fsf@building.gnus.org \
    --to=larsi@gnus.org \
    --cc=16198@debbugs.gnu.org \
    --cc=nakayamakenjiro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.