From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance
Date: Mon, 17 Mar 2014 20:20:02 +0100 [thread overview]
Message-ID: <87r460pr8d.fsf@Rainer.invalid> (raw)
In-Reply-To: 87ob14d4o7.fsf@bzg.ath.cx
Bastien writes:
> Can you tell a bit more about what's wrong with the test?
There is nothing wrong with those tests.
> If the patch is good and the tests are outdated, I'd rather
> fix the tests than revert the patch to re-revert it again.
No, the patch is bad, otherwise it wouldn't break the tests. It may
well be that there'd be more tests needed to catch that bug the patch
supposedly fixes.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada
next prev parent reply other threads:[~2014-03-17 19:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 6:28 [PATCH] Fixed bug in org-entry-get-with-inheritance Ilya Shlyakhter
2014-03-14 11:16 ` Bastien
2014-03-17 18:25 ` Achim Gratz
2014-03-17 19:08 ` Bastien
2014-03-17 19:20 ` Achim Gratz [this message]
2014-03-17 19:33 ` Bastien
2014-03-17 19:49 ` Achim Gratz
2014-03-17 20:35 ` Bastien
2014-03-17 20:51 ` Achim Gratz
2014-03-17 20:56 ` Bastien
2014-03-17 21:30 ` Ilya Shlyakhter
2014-03-17 21:43 ` Achim Gratz
2014-03-17 22:06 ` Ilya Shlyakhter
2014-03-17 22:13 ` Bastien
2014-03-18 12:01 ` Bastien
2014-03-18 15:14 ` Bastien
2014-03-18 15:38 ` Ilya Shlyakhter
2014-03-18 17:23 ` Achim Gratz
2014-03-18 18:27 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r460pr8d.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.