Tag setting mode creates two additional windows

Tag setting mode creates two additional windows

[Dmitry Gorbik]

Hello,

I am trying to enter the tag setting mode by pressing C-c C-c for the following org file:

#+TAGS: @work(w)  @home(h)  @tennisclub(t)
* some test

I have noticed that if the frame is large enough, when entering the tag setting mode Org will split the frame horizontally first and then will split the top window vertically. I end up with two windows with my org file and the other *Org tags* window. Is this done on purpose? Couldn’t find any information about this behavior.

I am using the latest nightly build of emacsformacosx, the latest org-mode and an .emacs with only org-mode enabled.

Thanks,
Dima

Re: Tag setting mode creates two additional windows

[Bastien]

Hi Dmitry,

Dmitry Gorbik <dgorbik@me.com> writes:

> I am trying to enter the tag setting mode by pressing C-c C-c for the following org file:
>
>
> #+TAGS: @work(w)  @home(h)  @tennisclub(t)
> * some test
>
>
> I have noticed that if the frame is large enough, when entering the
> tag setting mode Org will split the frame horizontally first and then
> will split the top window vertically. I end up with two windows with
> my org file and the other *Org tags* window. Is this done on
> purpose?

Nope.

> Couldn’t find any information about this behavior.

I can't reproduce this.

> I am using the latest nightly build of emacsformacosx, the latest
> org-mode and an .emacs with only org-mode enabled.

M-x org-version RET to tell us about the version -- I don't know what
version comes with emacsformacosx.  Maybe show us how you enable Org.

This is probably a bug specific to this version, since setting tags
from Org-mode does not do anything fancy with the window creation.
Perhaps other emacsformacosx can try to reproduce this as well.

HTH,

-- 
 Bastien

Re: Tag setting mode creates two additional windows

[Dmitry Gorbik]

This is my org-mode version:

Org-mode version 8.2.6 (release_8.2.6-961-g089a13 @ /Users/dgorbik/.emacs.d/org-mode/)

I could reproduce this in both Emacs 24.4.5 with emacsformacosx and Emacs 24.3.1 in console.

And here is the .emacs file:

(add-to-list 'load-path "~/.emacs.d/org-mode/")
(require 'org)

Thanks,
Dima

On May 15, 2014, at 1:59 AM, Bastien <bzg@gnu.org> wrote:

> Hi Dmitry,
> 
> Dmitry Gorbik <dgorbik@me.com> writes:
> 
>> I am trying to enter the tag setting mode by pressing C-c C-c for the following org file:
>> 
>> 
>> #+TAGS: @work(w)  @home(h)  @tennisclub(t)
>> * some test
>> 
>> 
>> I have noticed that if the frame is large enough, when entering the
>> tag setting mode Org will split the frame horizontally first and then
>> will split the top window vertically. I end up with two windows with
>> my org file and the other *Org tags* window. Is this done on
>> purpose?
> 
> Nope.
> 
>> Couldn’t find any information about this behavior.
> 
> I can't reproduce this.
> 
>> I am using the latest nightly build of emacsformacosx, the latest
>> org-mode and an .emacs with only org-mode enabled.
> 
> M-x org-version RET to tell us about the version -- I don't know what
> version comes with emacsformacosx.  Maybe show us how you enable Org.
> 
> This is probably a bug specific to this version, since setting tags
> from Org-mode does not do anything fancy with the window creation.
> Perhaps other emacsformacosx can try to reproduce this as well.
> 
> HTH,
> 
> -- 
> Bastien
> 

Re: Tag setting mode creates two additional windows

[Bastien]

Dmitry Gorbik <dgorbik@me.com> writes:

> This is my org-mode version:

Thanks -- maybe try to define "large enough" from your previous
report, so that other emacsformacosx users have more infos on how
to reproduce the bug.

-- 
 Bastien

Re: Tag setting mode creates two additional windows

[Dmitry Gorbik]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

It reproduces in console for me as well. 

Here is a screenshot to demonstrate the frame size and the issue:


Thanks,
Dima

On May 15, 2014, at 2:44 AM, Bastien <bzg@gnu.org> wrote:

> Dmitry Gorbik <dgorbik@me.com> writes:
> 
>> This is my org-mode version:
> 
> Thanks -- maybe try to define "large enough" from your previous
> report, so that other emacsformacosx users have more infos on how
> to reproduce the bug.
> 
> -- 
> Bastien
> 


[-- Attachment #2.1: Type: text/html, Size: 1157 bytes --]

[-- Attachment #2.2: Screen Shot 2014-05-15 at 2.18.52 AM.png --]
[-- Type: image/png, Size: 267790 bytes --]

Re: Tag setting mode creates two additional windows

[Dmitry Gorbik]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

I have found interesting email threads related to exactly same issue. But it looks like it was fixed since then, not sure why it reproduces for me again:

http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00443.html
http://article.gmane.org/gmane.emacs.orgmode/34802

Dima

On May 15, 2014, at 2:49 AM, Dmitry Gorbik <dgorbik@me.com> wrote:

> It reproduces in console for me as well. 
> 
> Here is a screenshot to demonstrate the frame size and the issue:
> <Screen Shot 2014-05-15 at 2.18.52 AM.png>
> 
> Thanks,
> Dima
> 
> On May 15, 2014, at 2:44 AM, Bastien <bzg@gnu.org> wrote:
> 
>> Dmitry Gorbik <dgorbik@me.com> writes:
>> 
>>> This is my org-mode version:
>> 
>> Thanks -- maybe try to define "large enough" from your previous
>> report, so that other emacsformacosx users have more infos on how
>> to reproduce the bug.
>> 
>> -- 
>> Bastien
>> 
> 


[-- Attachment #2: Type: text/html, Size: 1910 bytes --]

Re: Tag setting mode creates two additional windows

[Bastien]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

Dmitry Gorbik <dgorbik@me.com> writes:

> I have found interesting email threads related to exactly same issue.
> But it looks like it was fixed since then, not sure why it reproduces
> for me again:
>
> http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00443.html
> http://article.gmane.org/gmane.emacs.orgmode/34802

Can you try the attached patch against the master's HEAD?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: split-window.patch --]
[-- Type: text/x-diff, Size: 537 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 2661686..06c2b56 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14877,7 +14877,7 @@ Returns the new tags string, or nil to not change the current settings."
       (if expert
 	  (set-buffer (get-buffer-create " *Org tags*"))
 	(delete-other-windows)
-	(split-window-vertically)
+	(set-window-buffer (split-window-vertically) " *Org tags*")
 	(org-switch-to-buffer-other-window (get-buffer-create " *Org tags*")))
       (erase-buffer)
       (org-set-local 'org-done-keywords done-keywords)

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien

Re: Tag setting mode creates two additional windows

[Dmitry Gorbik]

[-- Attachment #1: Type: text/plain, Size: 66 bytes --]

This one didn’t work, I modified it like this to make it work:


[-- Attachment #2: tags-split-windows.patch --]
[-- Type: application/octet-stream, Size: 673 bytes --]

diff --git a/lisp/org.el b/lisp/org.el
index 2661686..5fcacb0 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14877,8 +14877,8 @@ Returns the new tags string, or nil to not change the current settings."
       (if expert
 	  (set-buffer (get-buffer-create " *Org tags*"))
 	(delete-other-windows)
-	(split-window-vertically)
-	(org-switch-to-buffer-other-window (get-buffer-create " *Org tags*")))
+	(set-window-buffer (split-window-vertically) (get-buffer-create " *Org tags*"))
+	(org-switch-to-buffer-other-window " *Org tags*"))
       (erase-buffer)
       (org-set-local 'org-done-keywords done-keywords)
       (org-fast-tag-insert "Inherited" inherited i-face "\n")

[-- Attachment #3: Type: text/plain, Size: 511 bytes --]



Dima

On May 15, 2014, at 3:37 AM, Bastien <bzg@gnu.org> wrote:

> Dmitry Gorbik <dgorbik@me.com> writes:
> 
>> I have found interesting email threads related to exactly same issue.
>> But it looks like it was fixed since then, not sure why it reproduces
>> for me again:
>> 
>> http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00443.html
>> http://article.gmane.org/gmane.emacs.orgmode/34802
> 
> Can you try the attached patch against the master's HEAD?
> 
> <split-window.patch>
> -- 
> Bastien

Re: Tag setting mode creates two additional windows

[Dmitry Gorbik]

Hello Bastien,

Do you think this can be committed to the trunk?

Thanks,
Dima

> On May 15, 2014, at 4:18 AM, Dmitry Gorbik <dgorbik@me.com> wrote:
> 
> This one didn’t work, I modified it like this to make it work:
> 
> <tags-split-windows.patch>
> 
> 
> Dima
> 
>> On May 15, 2014, at 3:37 AM, Bastien <bzg@gnu.org> wrote:
>> 
>> Dmitry Gorbik <dgorbik@me.com> writes:
>> 
>>> I have found interesting email threads related to exactly same issue.
>>> But it looks like it was fixed since then, not sure why it reproduces
>>> for me again:
>>> 
>>> http://lists.gnu.org/archive/html/emacs-orgmode/2010-12/msg00443.html
>>> http://article.gmane.org/gmane.emacs.orgmode/34802
>> 
>> Can you try the attached patch against the master's HEAD?
>> 
>> <split-window.patch>
>> -- 
>> Bastien
> 

Re: Tag setting mode creates two additional windows

[Bastien]

Hi Dmitry,

Dmitry Gorbik <dgorbik@me.com> writes:

> Do you think this can be committed to the trunk?

I'd rather clearly understand what's going on, I don't think
the patch is the final one.

Thanks,

PS: I'm handling past emails when I have some time like now,
so don't worry, the patch does not get lost.

-- 
 Bastien

Re: Tag setting mode creates two additional windows

[Bastien]

Hi Dmitry,

Dmitry Gorbik <dgorbik@me.com> writes:

> This one didn’t work, I modified it like this to make it work:

Okay, double-checked and applied in maint, thanks.

-- 
 Bastien

Re: Tag setting mode creates two additional windows

[Dmitry Gorbik]

Awesome, thanks a lot!

Dima

On May 20, 2014, at 1:21 PM, Bastien <bzg@gnu.org> wrote:

> Hi Dmitry,
> 
> Dmitry Gorbik <dgorbik@me.com> writes:
> 
>> This one didn’t work, I modified it like this to make it work:
> 
> Okay, double-checked and applied in maint, thanks.
> 
> -- 
> Bastien