From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#17577: 24.3.91; Error during redisplay prevent quitting. Date: Sat, 24 May 2014 19:27:14 +0200 Message-ID: <87r43jqe8d.fsf@gmail.com> References: <87lhtrzsod.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1400952509 30077 80.91.229.3 (24 May 2014 17:28:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 May 2014 17:28:29 +0000 (UTC) Cc: 17577@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 24 19:28:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WoFk1-0006bK-TP for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 May 2014 19:28:18 +0200 Original-Received: from localhost ([::1]:48863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoFk1-0000BF-Ct for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 May 2014 13:28:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoFjs-0000Aw-Nv for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 13:28:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WoFjm-0003Ry-Rl for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 13:28:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WoFjm-0003Rs-Og for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 13:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WoFjm-0002Mp-4a for bug-gnu-emacs@gnu.org; Sat, 24 May 2014 13:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2014 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17577-submit@debbugs.gnu.org id=B17577.14009524479013 (code B ref 17577); Sat, 24 May 2014 17:28:02 +0000 Original-Received: (at 17577) by debbugs.gnu.org; 24 May 2014 17:27:27 +0000 Original-Received: from localhost ([127.0.0.1]:59270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoFjC-0002LI-71 for submit@debbugs.gnu.org; Sat, 24 May 2014 13:27:26 -0400 Original-Received: from mail-wg0-f48.google.com ([74.125.82.48]:49680) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WoFj9-0002L0-4C for 17577@debbugs.gnu.org; Sat, 24 May 2014 13:27:24 -0400 Original-Received: by mail-wg0-f48.google.com with SMTP id k14so1934738wgh.19 for <17577@debbugs.gnu.org>; Sat, 24 May 2014 10:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=CnWO7wl8k7Cx5LX97sYLyAFK/+GfCuh8D+l6KHysL5s=; b=qXhbCeuiEY4S5I+G2lWETHSBPzDluoc+b8KhpF34S+8BhrRgAJ0xNY6sr3iXHMSOuW TBXi+tq55l2HTXPFJplEQBIOL6qg+Ebrnq8Jz3YiBa5n+eEydqqGWJzso1aiUGAK89OU Qq+/4ndOgLeBjT6oWglTaRNriyFOQu9+kr77iaf8UEePlOgGHIhuUa89xlGymKOyUT9s uPsrdee7n+Ux6iQgQ/GHui85r5vfgcSKmSt3TdfMIAeaYe7UGYLhLU0gZ37IDb5+7lhg nDQRdy7TtHsG8ZLmT+m7CuOPYuFGcFEmYCy3akIbDSTGDrv1KwDjisc7ZoeP/s/vzbyP WdLQ== X-Received: by 10.180.210.238 with SMTP id mx14mr12464201wic.61.1400952437262; Sat, 24 May 2014 10:27:17 -0700 (PDT) Original-Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPSA id fs5sm11622075wic.22.2014.05.24.10.27.15 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 24 May 2014 10:27:16 -0700 (PDT) User-agent: mu4e 0.9.9.6pre3; emacs 24.3.91.1 In-reply-to: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:89456 Archived-At: Stefan Monnier writes: > This doesn't come from pre-redisplay-function but from updating the > mode-line, and I can't remember modifying this code. And it seems that > this code has never run with inhibit-quit. At least, that's what > > (setq header-line-format '("" (:eval (format "inhibit-quit=%S" inhibit-quit)))) > > tells me in Emacs-23.4. Actually, I see that inhibit-quit is also nil > while running jit-lock, which baffles me. But indeed, if I add a slow > font-lock rule and hit C-g while it's processing that rule, I get: > > Error during redisplay: (quit) > > So I wonder why this is new. My best explanation is that it's actually > not new, but for some odd reason the timing has changed such that it > happens more often now. This one is indeed not new, the new thing is quit is involved here, and it seems your patch fix the issue with redisplay and this one too, don't know why though. > Since pre-redisplay-function is new in 24.4, it's important we fix the > bugs it introduces, so please remove this workaround from helm.el. Done. > The "when" check is redundant. Indeed yes, a vestige of code using only car, thanks. > Hmm... grepping around, "Emacs-lisp:" seems extremely unlikely, but > maybe you meant "Emacs-Lisp:" which I guess could potentially come from > the rarely used "menu in echo area" feature, i.e. "Emacs-Lisp" would > come from the name of a keymap. Why/how this happens, I don't know. I don't know too, seems fixed now after updating emacs-24 branch, same, don't know why. > I installed the patch below into the `emacs-24' branch. Could you try > it and see if it solves the problem for you? Yes it is fixed, many thanks for this. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997