From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 17577@debbugs.gnu.org
Subject: bug#17577: 24.3.91; Error during redisplay prevent quitting.
Date: Sat, 24 May 2014 19:27:14 +0200 [thread overview]
Message-ID: <87r43jqe8d.fsf@gmail.com> (raw)
In-Reply-To: <jwva9a72pqi.fsf-monnier+emacsbugs@gnu.org>
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> This doesn't come from pre-redisplay-function but from updating the
> mode-line, and I can't remember modifying this code. And it seems that
> this code has never run with inhibit-quit. At least, that's what
>
> (setq header-line-format '("" (:eval (format "inhibit-quit=%S" inhibit-quit))))
>
> tells me in Emacs-23.4. Actually, I see that inhibit-quit is also nil
> while running jit-lock, which baffles me. But indeed, if I add a slow
> font-lock rule and hit C-g while it's processing that rule, I get:
>
> Error during redisplay: (quit)
>
> So I wonder why this is new. My best explanation is that it's actually
> not new, but for some odd reason the timing has changed such that it
> happens more often now.
This one is indeed not new, the new thing is quit is involved here, and
it seems your patch fix the issue with redisplay and this one too, don't
know why though.
> Since pre-redisplay-function is new in 24.4, it's important we fix the
> bugs it introduces, so please remove this workaround from helm.el.
Done.
> The "when" check is redundant.
Indeed yes, a vestige of code using only car, thanks.
> Hmm... grepping around, "Emacs-lisp:" seems extremely unlikely, but
> maybe you meant "Emacs-Lisp:" which I guess could potentially come from
> the rarely used "menu in echo area" feature, i.e. "Emacs-Lisp" would
> come from the name of a keymap. Why/how this happens, I don't know.
I don't know too, seems fixed now after updating emacs-24 branch, same,
don't know why.
> I installed the patch below into the `emacs-24' branch. Could you try
> it and see if it solves the problem for you?
Yes it is fixed, many thanks for this.
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2014-05-24 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-24 4:50 bug#17577: 24.3.91; Error during redisplay prevent quitting Thierry Volpiatto
2014-05-24 7:38 ` Eli Zaretskii
[not found] ` <87k39bmuru.fsf@gmail.com>
2014-05-24 10:28 ` Eli Zaretskii
2014-05-24 11:07 ` Eli Zaretskii
2014-05-24 15:50 ` Stefan Monnier
2014-05-24 17:27 ` Thierry Volpiatto [this message]
2014-05-24 18:29 ` Ken Brown
2014-05-24 19:20 ` Eli Zaretskii
2014-05-24 20:39 ` Stefan Monnier
2014-05-24 22:13 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r43jqe8d.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=17577@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.