all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 18751@debbugs.gnu.org
Subject: bug#18751: 25.0.50; Unable to copy hidden (dot) files from remote shared server (Linux) to local machine (OSX).
Date: Mon, 03 Nov 2014 15:42:44 +0100	[thread overview]
Message-ID: <87r3xk2vmj.fsf@gmx.de> (raw)
In-Reply-To: <877fzvb7xt.fsf@gmx.de> (Michael Albinus's message of "Mon, 20 Oct 2014 07:56:30 +0200")

Michael Albinus <michael.albinus@gmx.de> writes:

Hi Keith,

>> Evaluating `(tramp-do-copy-or-rename-file 'copy filename new-filename
>> t t t)` is working well on all individual files, including
>> `.www.my.cnf`.
>>
>> `dired-do-copy` is working well on all individual files, and on
>> multiple marked files.
>>
>> However, `dired-do-copy` cannot handle any remote directory on the
>> remote server with files inside it.  Placing the cursor on any
>> directory on the remote server and issuing the command `dired-do-copy`
>> results in only that folder being copied to the local machine, but
>> noting inside it gets copied over.
>
> Thanks for this precision. Now I'm able to reproduce the problem, even
> with older Emacs versions.

Finally, I could fix it. I've committed the following patch to the
emacs-24 branch (shall appear in the trunk in a few days):

--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/emacs-24/lisp/net/tramp-sh.el.~117655~	2014-11-03 15:37:00.228854359 +0100
--- /home/albinus/src/emacs-24/lisp/net/tramp-sh.el	2014-11-03 15:22:10.311994500 +0100
***************
*** 2061,2071 ****
  KEEP-DATE is non-nil if NEWNAME should have the same timestamp as FILENAME."
    (with-temp-buffer
      ;; We must disable multibyte, because binary data shall not be
!     ;; converted.
      (set-buffer-multibyte nil)
      (let ((coding-system-for-read 'binary)
! 	  (jka-compr-inhibit t))
!       (insert-file-contents-literally filename))
      ;; We don't want the target file to be compressed, so we let-bind
      ;; `jka-compr-inhibit' to t.
      (let ((coding-system-for-write 'binary)
--- 2061,2075 ----
  KEEP-DATE is non-nil if NEWNAME should have the same timestamp as FILENAME."
    (with-temp-buffer
      ;; We must disable multibyte, because binary data shall not be
!     ;; converted.  `insert-file-contents-literally' does not support
!     ;; file name handlers for GNU Emacs; we must create a local copy
!     ;; therefore.
      (set-buffer-multibyte nil)
      (let ((coding-system-for-read 'binary)
! 	  (jka-compr-inhibit t)
! 	  (tmpfile (file-local-copy filename)))
!       (insert-file-contents-literally (or tmpfile filename))
!       (when tmpfile (delete-file tmpfile)))
      ;; We don't want the target file to be compressed, so we let-bind
      ;; `jka-compr-inhibit' to t.
      (let ((coding-system-for-write 'binary)
--8<---------------cut here---------------end--------------->8---

Could you, please, check it?

Best regards, Michael.





  reply	other threads:[~2014-11-03 14:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 23:03 bug#18751: 25.0.50; Unable to copy hidden (dot) files from remote shared server (Linux) to local machine (OSX) Keith David Bershatsky
2014-10-17  6:15 ` Michael Albinus
2014-10-18  4:23 ` Keith David Bershatsky
2014-10-18 19:51   ` Michael Albinus
2014-10-19  3:37 ` Keith David Bershatsky
2014-10-19  8:57 ` Michael Albinus
2014-10-19 14:46 ` Keith David Bershatsky
2014-10-20  5:56   ` Michael Albinus
2014-11-03 14:42     ` Michael Albinus [this message]
2014-11-06  3:41 ` Keith David Bershatsky
2014-11-06  8:27   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3xk2vmj.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=18751@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.