From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] gnutls: Add SNI support Date: Mon, 24 Nov 2014 14:08:47 +0100 Message-ID: <87r3ws3fvk.fsf@toke.dk> References: <87wq6k3i99.fsf@toke.dk> <87oarwhjem.fsf@zigzag.favinet> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1416834564 11434 80.91.229.3 (24 Nov 2014 13:09:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Nov 2014 13:09:24 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 24 14:09:19 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XstOI-0006nU-12 for ged-emacs-devel@m.gmane.org; Mon, 24 Nov 2014 14:09:18 +0100 Original-Received: from localhost ([::1]:52548 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XstOH-0000zr-H4 for ged-emacs-devel@m.gmane.org; Mon, 24 Nov 2014 08:09:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XstNz-0000xv-TQ for emacs-devel@gnu.org; Mon, 24 Nov 2014 08:09:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XstNv-00078S-Fl for emacs-devel@gnu.org; Mon, 24 Nov 2014 08:08:59 -0500 Original-Received: from mail2.tohojo.dk ([77.235.48.147]:35750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XstNv-00078D-8E for emacs-devel@gnu.org; Mon, 24 Nov 2014 08:08:55 -0500 X-Virus-Scanned: amavisd-new at mail2.tohojo.dk Original-Received: by alrua-kau.kau.toke.dk (Postfix, from userid 1000) id 21EFF2A5530; Mon, 24 Nov 2014 14:08:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toke.dk; s=201310; t=1416834155; bh=RYVd0AgjTM4oNVU5QbJIikjcC6OA05lcHvldGYexDrs=; h=From:To:Subject:In-Reply-To:References:Date; b=guj4Sv7MBmZpCzFubbFkHTxpo9CpD+8tfWCUJp+CmanTb+SdSXo3IMUoepTgNiNqc /7j2ovv0+8Ja/Obpyo5MInSx09dJyi9YoQjcqnkWR3jkwNTYG32EndNiMhj9BGgf6q uNzkGo/Q1F8kbUIqLHVOd/HbKcsP9KDtv/lQKM2Q= In-Reply-To: <87oarwhjem.fsf@zigzag.favinet> (Thien-Thi Nguyen's message of "Mon, 24 Nov 2014 13:28:49 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.235.48.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178170 Archived-At: Thien-Thi Nguyen writes: > Aside from the whitespace and brace placement, this code is buggy: =E2=80= =98c=E2=80=99 > is of type =E2=80=98char *=E2=80=99 and cannot be meaningfully compared d= irectly to > 'a'. Ah yes, was missing a pointer deref I guess. But as I noted, there's probably a better way to check this. Not sure I'm the right person to integrate this probably; can make it a feature request instead? Please support SNI... :) -Toke