From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nicolas Richard Newsgroups: gmane.emacs.bugs Subject: bug#19932: 25.0.50; doc string of `elisp--eval-last-sexp' Date: Wed, 25 Feb 2015 13:12:00 +0100 Message-ID: <87r3techrj.fsf@yahoo.fr> References: <54ECE6C3.3000602@yandex.ru> <87egpee009.fsf@yahoo.fr> <54EDAF58.50904@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1424866343 1252 80.91.229.3 (25 Feb 2015 12:12:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2015 12:12:23 +0000 (UTC) Cc: Nicolas Richard , 19932@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 13:12:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQap1-0004uc-P3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 13:12:11 +0100 Original-Received: from localhost ([::1]:53912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQap1-0006o1-4P for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 07:12:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQaow-0006n2-U9 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 07:12:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQaos-0007mk-To for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 07:12:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQaos-0007mg-PF for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 07:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YQaos-00069R-Ge for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 07:12:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Feb 2015 12:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19932-submit@debbugs.gnu.org id=B19932.142486628423594 (code B ref 19932); Wed, 25 Feb 2015 12:12:02 +0000 Original-Received: (at 19932) by debbugs.gnu.org; 25 Feb 2015 12:11:24 +0000 Original-Received: from localhost ([127.0.0.1]:57379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQaoG-00068T-Dj for submit@debbugs.gnu.org; Wed, 25 Feb 2015 07:11:24 -0500 Original-Received: from mxin.ulb.ac.be ([164.15.128.112]:47491) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQaoE-00068J-0L for 19932@debbugs.gnu.org; Wed, 25 Feb 2015 07:11:22 -0500 Original-Received: from mathsrv4.ulb.ac.be (HELO localhost) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 25 Feb 2015 13:11:20 +0100 In-Reply-To: <54EDAF58.50904@yandex.ru> (Dmitry Gutov's message of "Wed, 25 Feb 2015 13:17:44 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99797 Archived-At: --=-=-= Content-Type: text/plain Dmitry Gutov writes: > On 02/25/2015 12:52 PM, Nicolas Richard wrote: > >> FWIW, I like when functions are documented, even private ones. > > Would you like to enforce your preference and provide a patch that > improves on the discussed drawbacks in that docstring? Would the following fit ? (I should be able to push it, if it turns out to be ok.) It's not as precise as what Drew suggested, but I didn't feel like being too verbose. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-progmodes-elisp-mode.el-elisp-eval-last-sexp-Do.patch >From 31d11bc29fd5157f2ff0f41e6d5d39b1115fcf8f Mon Sep 17 00:00:00 2001 From: Nicolas Richard Date: Wed, 25 Feb 2015 13:07:43 +0100 Subject: [PATCH] lisp/progmodes/elisp-mode.el (elisp--eval-last-sexp): Document argument. Fixes: 19932 --- lisp/ChangeLog | 4 ++++ lisp/progmodes/elisp-mode.el | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index e32dab0..f4f6097 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,7 @@ +2015-02-25 Nicolas Richard + + * progmodes/elisp-mode.el (elisp--eval-last-sexp): Document argument. + 2014-12-23 Nicolas Richard * simple.el (count-words-region): Act on buffer if there is no region. diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index b2c5fbf..42e946c 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -883,8 +883,8 @@ (define-obsolete-function-alias 'preceding-sexp 'elisp--preceding-sexp "25.1") (defun elisp--eval-last-sexp (eval-last-sexp-arg-internal) "Evaluate sexp before point; print value in the echo area. -With argument, print output into current buffer. -With a zero prefix arg, print output with no limit on the length +If EVAL-LAST-SEXP-ARG-INTERNAL is non-nil, print output into current buffer. +If EVAL-LAST-SEXP-ARG-INTERNAL is `0', print output with no limit on the length and level of lists, and include additional formats for integers \(octal, hexadecimal, and character)." (let ((standard-output (if eval-last-sexp-arg-internal (current-buffer) t))) -- 2.1.4 --=-=-= Content-Type: text/plain -- Nicolas Richard --=-=-=--