From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>, 19932@debbugs.gnu.org
Subject: bug#19932: 25.0.50; doc string of `elisp--eval-last-sexp'
Date: Wed, 25 Feb 2015 13:12:00 +0100 [thread overview]
Message-ID: <87r3techrj.fsf@yahoo.fr> (raw)
In-Reply-To: <54EDAF58.50904@yandex.ru> (Dmitry Gutov's message of "Wed, 25 Feb 2015 13:17:44 +0200")
[-- Attachment #1: Type: text/plain, Size: 457 bytes --]
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 02/25/2015 12:52 PM, Nicolas Richard wrote:
>
>> FWIW, I like when functions are documented, even private ones.
>
> Would you like to enforce your preference and provide a patch that
> improves on the discussed drawbacks in that docstring?
Would the following fit ? (I should be able to push it, if it turns out
to be ok.)
It's not as precise as what Drew suggested, but I didn't feel like being
too verbose.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-progmodes-elisp-mode.el-elisp-eval-last-sexp-Do.patch --]
[-- Type: text/x-diff, Size: 1679 bytes --]
From 31d11bc29fd5157f2ff0f41e6d5d39b1115fcf8f Mon Sep 17 00:00:00 2001
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
Date: Wed, 25 Feb 2015 13:07:43 +0100
Subject: [PATCH] lisp/progmodes/elisp-mode.el (elisp--eval-last-sexp):
Document argument.
Fixes: 19932
---
lisp/ChangeLog | 4 ++++
lisp/progmodes/elisp-mode.el | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index e32dab0..f4f6097 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,7 @@
+2015-02-25 Nicolas Richard <theonewiththeevillook@yahoo.fr>
+
+ * progmodes/elisp-mode.el (elisp--eval-last-sexp): Document argument.
+
2014-12-23 Nicolas Richard <theonewiththeevillook@yahoo.fr>
* simple.el (count-words-region): Act on buffer if there is no region.
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index b2c5fbf..42e946c 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -883,8 +883,8 @@ (define-obsolete-function-alias 'preceding-sexp 'elisp--preceding-sexp "25.1")
(defun elisp--eval-last-sexp (eval-last-sexp-arg-internal)
"Evaluate sexp before point; print value in the echo area.
-With argument, print output into current buffer.
-With a zero prefix arg, print output with no limit on the length
+If EVAL-LAST-SEXP-ARG-INTERNAL is non-nil, print output into current buffer.
+If EVAL-LAST-SEXP-ARG-INTERNAL is `0', print output with no limit on the length
and level of lists, and include additional formats for integers
\(octal, hexadecimal, and character)."
(let ((standard-output (if eval-last-sexp-arg-internal (current-buffer) t)))
--
2.1.4
[-- Attachment #3: Type: text/plain, Size: 21 bytes --]
--
Nicolas Richard
next prev parent reply other threads:[~2015-02-25 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 21:20 bug#19932: 25.0.50; doc string of `elisp--eval-last-sexp' Drew Adams
2015-02-24 21:01 ` Dmitry Gutov
2015-02-24 21:26 ` Drew Adams
2015-02-25 4:06 ` Stefan Monnier
2015-02-25 10:52 ` Nicolas Richard
2015-02-25 11:17 ` Dmitry Gutov
2015-02-25 12:12 ` Nicolas Richard [this message]
2015-02-25 12:44 ` Dmitry Gutov
2015-02-25 15:18 ` Nicolas Richard
2015-02-25 16:39 ` Drew Adams
2015-02-25 16:36 ` Drew Adams
2015-02-25 16:39 ` Dmitry Gutov
2015-02-25 16:45 ` Drew Adams
2015-02-25 16:49 ` Nicolas Richard
2015-02-25 17:05 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3techrj.fsf@yahoo.fr \
--to=theonewiththeevillook@yahoo.fr \
--cc=19932@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.