Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

[Leo Liu]

On 2015-06-25 19:25 +0800, Oleh Krehel wrote:
> diff --git a/lisp/emacs-lisp/cl-indent.el b/lisp/emacs-lisp/cl-indent.el
> index 57da715..9314419 100644
> --- a/lisp/emacs-lisp/cl-indent.el
> +++ b/lisp/emacs-lisp/cl-indent.el
> @@ -827,7 +827,7 @@ optional\\|rest\\|key\\|allow-other-keys\\|aux\\|whole\\|body\\|environment\
>             (with-accessors . multiple-value-bind)
>             (with-condition-restarts . multiple-value-bind)
>  	   (with-compilation-unit (&lambda &body))
> -           (with-output-to-string (4 2))
> +           (with-output-to-string 0)
>             (with-slots . multiple-value-bind)
>             (with-standard-io-syntax (2)))))
>    (dolist (el l)

Are you sure you are doing the right thing?

Leo

Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

[Oleh Krehel]

Leo Liu <sdl.web@gmail.com> writes:

> On 2015-06-25 19:25 +0800, Oleh Krehel wrote:
>> diff --git a/lisp/emacs-lisp/cl-indent.el b/lisp/emacs-lisp/cl-indent.el
>> index 57da715..9314419 100644
>> --- a/lisp/emacs-lisp/cl-indent.el
>> +++ b/lisp/emacs-lisp/cl-indent.el
>> @@ -827,7 +827,7 @@ optional\\|rest\\|key\\|allow-other-keys\\|aux\\|whole\\|body\\|environment\
>>             (with-accessors . multiple-value-bind)
>>             (with-condition-restarts . multiple-value-bind)
>>  	   (with-compilation-unit (&lambda &body))
>> -           (with-output-to-string (4 2))
>> +           (with-output-to-string 0)
>>             (with-slots . multiple-value-bind)
>>             (with-standard-io-syntax (2)))))
>>    (dolist (el l)
>
> Are you sure you are doing the right thing?

Yes.,

With this in my config:

    (setq lisp-indent-function 'common-lisp-indent-function)

The previous (bad) indent was this:

    (with-output-to-string
        (foo)
      (bar))

The fixed indent is this:

    (with-output-to-string
      (foo)
      (bar))

Which makes sense and is consistent with the indent declaration of
`with-output-to-string', as I mentioned in the commit.

    (defmacro with-output-to-string (&rest body)
      "Execute BODY, return the text it sent to `standard-output', as a string."
      (declare (indent 0) (debug t))
      `(let ((standard-output
    	  (get-buffer-create (generate-new-buffer-name " *string-output*"))))
         (unwind-protect
    	 (progn
    	   (let ((standard-output standard-output))
    	     ,@body)
    	   (with-current-buffer standard-output
    	     (buffer-string)))
           (kill-buffer standard-output))))

I even checked the args of `with-output-to-string' for SBCL, just in
case: they are &rest.

Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

[John Mastro]

Oleh Krehel <ohwoeowho@gmail.com> wrote:
> I even checked the args of `with-output-to-string' for SBCL, just in
> case: they are &rest.

Hm, not sure why it showed you that, but it's not right.

CL-USER> (lisp-implementation-type)
"SBCL"
CL-USER> (describe 'with-output-to-string)
COMMON-LISP:WITH-OUTPUT-TO-STRING
  [symbol]

WITH-OUTPUT-TO-STRING names a macro:
  Lambda-list: ((VAR &OPTIONAL STRING &KEY (ELEMENT-TYPE ''CHARACTER))
                &BODY FORMS-DECLS)
  Source file: SYS:SRC;CODE;MACROS.LISP

-- 
john

Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

[John Mastro]

John Mastro <john.b.mastro@gmail.com> wrote:
>> I even checked the args of `with-output-to-string' for SBCL, just in
>> case: they are &rest.
>
> Hm, not sure why it showed you that, but it's not right.

But the best source for this sort of thing is the CLHS:
http://www.lispworks.com/documentation/HyperSpec/Body/m_w_out_.htm#with-output-to-string

-- 
john

Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

[Stefan Monnier]

> With this in my config:
>     (setq lisp-indent-function 'common-lisp-indent-function)

You're tweaking the common-lisp indentation rules to work for the Elisp
language, at the detriment of the Common-Lisp language (because their
with-output-to-string are rather different)


        Stefan

Re: master 659199f: lisp/emacs-lisp/cl-indent.el: Fix indent of with-output-to-string

[Oleh Krehel]

Oleh Krehel <ohwoeowho@gmail.com> writes:

> Leo Liu <sdl.web@gmail.com> writes:
>
>> On 2015-06-25 19:25 +0800, Oleh Krehel wrote:
>>> diff --git a/lisp/emacs-lisp/cl-indent.el b/lisp/emacs-lisp/cl-indent.el
>>> index 57da715..9314419 100644
>>> --- a/lisp/emacs-lisp/cl-indent.el
>>> +++ b/lisp/emacs-lisp/cl-indent.el
>>> @@ -827,7 +827,7 @@ optional\\|rest\\|key\\|allow-other-keys\\|aux\\|whole\\|body\\|environment\
>>>             (with-accessors . multiple-value-bind)
>>>             (with-condition-restarts . multiple-value-bind)
>>>  	   (with-compilation-unit (&lambda &body))
>>> -           (with-output-to-string (4 2))
>>> +           (with-output-to-string 0)
>>>             (with-slots . multiple-value-bind)
>>>             (with-standard-io-syntax (2)))))
>>>    (dolist (el l)
>>
>> Are you sure you are doing the right thing?
>
> Yes.

By bad. I've looked at (swank-backend:arglist 'with-output-to-string)
which returned (&REST SB-C::ARGS). I extrapolated from Elisp and thought
that they do the same thing. Thanks for fixing it.