From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.help Subject: Re: use Elisp to improve your Elisp - some code issues Date: Sat, 01 Aug 2015 06:09:05 +0200 Message-ID: <87r3nnd50e.fsf@nl106-137-147.student.uu.se> References: <877fphvymu.fsf@kuiper.lan.informatimago.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438402269 8725 80.91.229.3 (1 Aug 2015 04:11:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 1 Aug 2015 04:11:09 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sat Aug 01 06:11:00 2015 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZLO8R-00010X-3o for geh-help-gnu-emacs@m.gmane.org; Sat, 01 Aug 2015 06:10:59 +0200 Original-Received: from localhost ([::1]:46701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLO8Q-0007fQ-93 for geh-help-gnu-emacs@m.gmane.org; Sat, 01 Aug 2015 00:10:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLO8F-0007eI-JE for help-gnu-emacs@gnu.org; Sat, 01 Aug 2015 00:10:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZLO8C-0007I1-A5 for help-gnu-emacs@gnu.org; Sat, 01 Aug 2015 00:10:47 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:53547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZLO8C-0007Hf-2P for help-gnu-emacs@gnu.org; Sat, 01 Aug 2015 00:10:44 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZLO8A-0000qO-7S for help-gnu-emacs@gnu.org; Sat, 01 Aug 2015 06:10:42 +0200 Original-Received: from nl106-137-228.student.uu.se ([130.243.137.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 01 Aug 2015 06:10:42 +0200 Original-Received: from embe8573 by nl106-137-228.student.uu.se with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 01 Aug 2015 06:10:42 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: help-gnu-emacs@gnu.org Original-Lines: 119 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: nl106-137-228.student.uu.se Mail-Copies-To: never User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) Cancel-Lock: sha1:WWx7eMsnFciIT2WDn3EJaIP434c= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:106177 Archived-At: "Pascal J. Bourguignon" writes: > It's not so much a temporary buffer than a buffer > that is not backed by a file, that you want. Indeed, good clarification. > You want your buffer to be visible by the user. > The convention for this type of buffer is to name it > with stars around "*Results*". OK, done. > If you want such a buffer but not visible to the > user, add a prefix space: > > " *PrivateResults*" > > You can see the current "invisible" buffer with C-x > b SPC TAB or all the buffers with (buffer-list) Interesting, but of course the buffer should be accessible the ordinary way as you might fix one occurence, get back to the hit list, examine the next hit, and so on. >> Issue two is to not kill buffers that were already >> open at invocation - I can solve that by checking >> if there is such a buffer, but I suspect there is >> a better way to do these kind of things all in the >> background, rather than the `find-file' and then >> conditionally `kill-buffer' combo. > > I don't think there's another way. > > In my opinion, it's not too important a feature; in > my own with-file macro (used by with-files), > I didn't check for pre-existing buffers. Here it is very important! Because say that you have a couple of Elisp files open. Then it strikes you you can do (or a b) instead of (if a a b) while working on one of them. So you think, did I do that in any of my other Elisp files? You apply the tool - boom, all buffers killed! See the code (last) for how the situation can be solved (?). > I never noted any message from downcase; what do > you get? Messages :) In the form of: "Line X". But it wasn't `downcase' but `what-line'! > In anycase, it is a basic precept to never mix I/O > with computing in a single function. Indeed, and I want data, not I/O. `line-number-at-pos' did it as mentioned by anther poster. The code: ;; This file: http://user.it.uu.se/~embe8573/conf/emacs-init/search-regexp-in-files.el (defun files-as-list (file-regexp) (split-string (with-temp-buffer (call-process-shell-command (format "ls %s" file-regexp) nil t) ; no INFILE, temp BUFFER (buffer-substring (point-min) (point-max)) ))) (require 'cl) (defalias 'cl-set-xor 'cl-set-exclusive-or) (defun search-regexp-in-files (file-regexp regexp) (let ((paths (files-as-list file-regexp)) (regexp-hits "*regexp-hits*") (hits nil) ) (get-buffer-create regexp-hits) (let ((buffers (buffer-list))) ; get list to see if we opened the file - (with-current-buffer regexp-hits (erase-buffer)) (dolist (p paths) (let ((buffer (find-file p)) ; here - (kill-later (cl-set-xor buffers (buffer-list))) ) ; by comparing! (with-current-buffer buffer (goto-char (point-min)) (while (re-search-forward regexp nil t) ; no BOUND, NOERROR (setq hits t) (let ((hit-line (line-number-at-pos))) (with-current-buffer regexp-hits (insert (format "%s (%s)\n" p hit-line))))) (when kill-later (kill-buffer buffer) )))) (if hits (progn (switch-to-buffer regexp-hits) (set-buffer-modified-p nil) (goto-char (point-min)) ) (message "No hits!") )))) ;; use this to test (when nil ;; find "kill" - should be some hits even for pacifists (search-regexp-in-files "~/.emacs.d/emacs-init/*.el" "kill") ;; find the construct (if a a b) if you want to replace it with (or a b) ;; if it works, when applied to this file, it should find the example above! (search-regexp-in-files (buffer-file-name) "([[:space:]\n]*if[[:space:]\n]+\\(.*\\)[[:space:]\n]+\\1[[:space:]\n]+\\(.*\\))" ) ) (provide 'search-regexp-in-files) -- underground experts united http://user.it.uu.se/~embe8573