From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#21435: 25.0.50; file-notify has problems after renames Date: Fri, 11 Sep 2015 11:53:47 +0200 Message-ID: <87r3m5l1sk.fsf@gmx.de> References: <87y4gh47sr.fsf@gnu.org> <83k2s07vaf.fsf@gnu.org> <87fv2ovlcr.fsf@gmx.de> <83613k7owe.fsf@gnu.org> <87si6og17z.fsf@gnu.org> <877fnzv4r6.fsf@gmx.de> <87egi7o1s1.fsf@gnu.org> <871te7tk9i.fsf@gnu.org> <87oahatt4p.fsf@gmx.de> <87a8sunve8.fsf@gnu.org> <87si6mi2oy.fsf@gmx.de> <87613inkpx.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441965270 15470 80.91.229.3 (11 Sep 2015 09:54:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Sep 2015 09:54:30 +0000 (UTC) Cc: 21435@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 11 11:54:18 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZaL24-0008Qs-DJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Sep 2015 11:54:12 +0200 Original-Received: from localhost ([::1]:55121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaL23-0005x9-TL for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Sep 2015 05:54:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaL1x-0005vz-Um for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2015 05:54:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaL1u-0004DQ-K8 for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2015 05:54:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaL1u-0004DG-FM for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2015 05:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZaL1u-00014S-8j for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2015 05:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Sep 2015 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21435-submit@debbugs.gnu.org id=B21435.14419652324100 (code B ref 21435); Fri, 11 Sep 2015 09:54:02 +0000 Original-Received: (at 21435) by debbugs.gnu.org; 11 Sep 2015 09:53:52 +0000 Original-Received: from localhost ([127.0.0.1]:56173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZaL1j-000143-Uk for submit@debbugs.gnu.org; Fri, 11 Sep 2015 05:53:52 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:64694) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZaL1i-00013w-8y for 21435@debbugs.gnu.org; Fri, 11 Sep 2015 05:53:50 -0400 Original-Received: from detlef.gmx.de ([79.195.7.210]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MAyZg-1ZSbFY158e-009z7L; Fri, 11 Sep 2015 11:53:48 +0200 In-Reply-To: <87613inkpx.fsf@gnu.org> (Tassilo Horn's message of "Thu, 10 Sep 2015 21:22:02 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:Jjiu/OStVUp04bIaNdpJtLvBGhPk3w6W///3y4VmDTikCh2Be7g eevlCvLobipav/nATp02TNEqu2BMMG2FG29hDmcBu5joZNDiFCeeWV/5OCo4d5T7nzo1l8E D3v4ULmsN2oUOR+Lw3XWxZvJwPy1vEXtDr28IWjj7gJpqEQoTSmFpy4Y8nPkxEjRpuZ6/Cr Uu79CuGYEUeXO5rnVKUvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:rqog/NOolXE=:eR2jEyPlceMVjCwueTkm79 KxjJ1Gtdq4sjT6Lr39S/S1nB9TI7e72waU/nVhrNUZkwu5H/TEjLWqeWTisjFSIglK3l8GxPz gEJBVm+cNRw5bJg713ZTNvjW6R6DqIHn+eCrzHISva6jc/XfHus3BcaaQbpXQdzbcH/BBpLTl OqcuC7YZMWGZJuGQZB5bsJfqcA3z/kF4dgTwWnKHMNf/Nchx8hwYCVHBNIn6vdw2OtCUcchzI k1eZddurrxpqqnotykPRoVyuigzEMgFw32BdTErCYUV1L5V4wGV5VjZMsVZUq5rXrthNcxujW zb+NgVjIV8XY8BSg5eR+A4kke1XAI6/r16U2zFbjuOvk3srEbP/n1tfWM0XbqOD57HIqzotWY lnSNpVyZjsAgFLxEY28e6d40A9TAdXM5tGYcEMwqaw6YdtW7e+HujSgxfBBui7tGdR8b1xDxY q0yNP6kmD5RS9ymG4i3lY5cByIcFUQz1z7oYNfFo/Z29/Yi5uOAxnDFmxVG/h82dW9irtYWzY /LH5DH75x0Buh7Ikhoes4NLTcacPJZ6p53dAVlD5cmpaytIkBzv9+sxiNUWjDCgm0SRG2su+1 k+U5THIBVEwpARmxgEFsTAEw0K1Axa5WixMaYFarOyAr99m31F/diJ4sXKvGhTZwkNCZEHfxs y6hSeSg7H7yxYUcXCMjZcd62NRyKhQHv7kr3SxljHzBFkN+1BLc+MF1m/tmkQpSQIQtA3x2Z5 umye427YQBGVRD1uhG6at0sQZQtcz9MYouWbVw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106406 Archived-At: Tassilo Horn writes: >>> I've added a new macro to the tests now which lets you do things this >>> way: >>> >>> ;; Check creation, change, and deletion. >>> (file-notify--test-with-events >>> 3 3 (lambda (events) >>> (should (equal '(created changed deleted) >>> (mapcar #'cadr events)))) >>> (write-region >>> "any text" nil file-notify--test-tmpfile nil 'no-message) >>> (delete-file file-notify--test-tmpfile)) >>> >>> This means we're waiting for 3 events for at most 3 seconds, and then >>> apply the lambda to the received events. The rest is the code which >>> causes the events to be emitted. >> >> That's good, yes. Please add a docstring to that macro (boring, I >> know, but it will help other people like Eli and me). > > Done. Thanks. Another point is whether we always can expect that all native libraries will report exactly the same number of events, and then whether they report them exactly in the same order (you expect '(created changed deleted) here). Let's see how the test cases evolve, maybe we need more tolerant tests. >> One point: you don't call any longer `read-event'. I believe it still >> makes sense; IIRC I did it because sometimes you must trigger Emacs to >> check all its file descriptors for new events. > > I still do. That macro uses `file-notify--wait-for-events' to wait > until all N events have arrived before calling the ASSERT-FN. Yep, I've overseen this. OK. > Hm, then I wonder what causes these extreme delays here. The remote > autorevert test really takes at least 20 seconds here. But I have no > issues using TRAMP with its ssh method for accessing really remote > files... Now I see it also, but only when running in interactive mode. In batch mode, there is no serious delay. Will contact the Tramp maintainer, again. > Bye, > Tassilo Best regards, Michael.