From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch) Date: Mon, 28 Dec 2015 18:13:05 +0100 Message-ID: <87r3i6v6n2.fsf@gnus.org> References: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451323423 26898 80.91.229.3 (28 Dec 2015 17:23:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 17:23:43 +0000 (UTC) Cc: 22257@debbugs.gnu.org To: Benjamin Riefenstahl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 28 18:23:32 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDbW2-0004Av-Gh for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 18:23:26 +0100 Original-Received: from localhost ([::1]:45499 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbW1-0005kG-Nw for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 12:23:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbN0-0005C8-Un for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:14:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDbMw-0002M7-0C for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:14:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39017) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDbMv-0002M1-Ti for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:14:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDbMv-0005Gx-Qd for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 12:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22257-submit@debbugs.gnu.org id=B22257.145132281020217 (code B ref 22257); Mon, 28 Dec 2015 17:14:01 +0000 Original-Received: (at 22257) by debbugs.gnu.org; 28 Dec 2015 17:13:30 +0000 Original-Received: from localhost ([127.0.0.1]:46619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDbMQ-0005G1-0C for submit@debbugs.gnu.org; Mon, 28 Dec 2015 12:13:30 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:39814) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDbMO-0005Ft-Dq for 22257@debbugs.gnu.org; Mon, 28 Dec 2015 12:13:28 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDbM2-0002rG-4f; Mon, 28 Dec 2015 18:13:06 +0100 In-Reply-To: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> (Benjamin Riefenstahl's message of "Mon, 28 Dec 2015 17:38:58 +0100") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aDbM2-0002rG-4f MailScanner-NULL-Check: 1451927587.18981@Elf5EDxkEvnH5I17aPuMUQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110897 Archived-At: Benjamin Riefenstahl writes: > When I have visited a page in eww that contains Hebrew text and than > switch to a non-Hebrew page, bidi-paragraph-direction is still set RTL. > A simple fix is attached. The bug will still happen if the LTR page > does not have an element at all, but we may not care. I think we do care. :-) Does the following fix the problem? (Included in the Emacs 25 branch in a jiffy...) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 5755a94..d455577 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -401,6 +401,7 @@ eww-display-html (source (and (null document) (buffer-substring (point) (point-max))))) (with-current-buffer buffer + (setq bidi-paragraph-direction 'left-to-right) (plist-put eww-data :source source) (plist-put eww-data :dom document) (let ((inhibit-read-only t) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no