:tracker in eieio classes

:tracker in eieio classes

[Lars Ingebrigtsen]

When compiling registry.el, I get the following:

ELC      gnus/registry.elc

In toplevel form:
gnus/registry.el:182:21:Warning: Unknown slot `:tracker'

I'm not very familiar with eieio, so I have no idea whether this is a
real bug or what to do about it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: :tracker in eieio classes

[Eric Abrahamsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> When compiling registry.el, I get the following:
>
> ELC      gnus/registry.elc
>
> In toplevel form:
> gnus/registry.el:182:21:Warning: Unknown slot `:tracker'
>
> I'm not very familiar with eieio, so I have no idea whether this is a
> real bug or what to do about it.

I've noticed that, while tag references to slots work, the compiler
wants a symbol. I think if you just switch that to (oref db 'tracker) it
should be quiet. Or (eieio-oref db 'tracker).

Eric

Re: :tracker in eieio classes

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I've noticed that, while tag references to slots work, the compiler
> wants a symbol. I think if you just switch that to (oref db 'tracker) it
> should be quiet. Or (eieio-oref db 'tracker).

Then it says

In toplevel form:
gnus/registry.el:182:21:Warning: Unknown slot `(quote tracker)'

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: :tracker in eieio classes

[Chris Feng]

>> I've noticed that, while tag references to slots work, the compiler
>> wants a symbol. I think if you just switch that to (oref db 'tracker) it
>> should be quiet. Or (eieio-oref db 'tracker).
>
> Then it says
>
> In toplevel form:
> gnus/registry.el:182:21:Warning: Unknown slot `(quote tracker)'

It should be (oref db tracker).

Re: :tracker in eieio classes

[Eric Abrahamsen]

Chris Feng <chris.w.feng@gmail.com> writes:

>>> I've noticed that, while tag references to slots work, the compiler
>>> wants a symbol. I think if you just switch that to (oref db 'tracker) it
>>> should be quiet. Or (eieio-oref db 'tracker).
>>
>> Then it says
>>
>> In toplevel form:
>> gnus/registry.el:182:21:Warning: Unknown slot `(quote tracker)'
>
> It should be (oref db tracker).

Whoops, sorry for the hasty answer. I usually use eieio-oref, which
is a function and wants a symbol. `oref' is defined as a macro:

(defmacro oref (obj slot)
  (declare (debug (form symbolp)))
  `(eieio-oref ,obj (quote ,slot)))

I've always been a little confused about whether one thing or the other
was preferred.

Re: :tracker in eieio classes

[Lars Ingebrigtsen]

Chris Feng <chris.w.feng@gmail.com> writes:

>>> I've noticed that, while tag references to slots work, the compiler
>>> wants a symbol. I think if you just switch that to (oref db 'tracker) it
>>> should be quiet. Or (eieio-oref db 'tracker).
>>
>> Then it says
>>
>> In toplevel form:
>> gnus/registry.el:182:21:Warning: Unknown slot `(quote tracker)'
>
> It should be (oref db tracker).

There's also code like:

(cl-defmethod initialize-instance :after ((this registry-db) slots)
  "Set value of data slot of THIS after initialization."
  (with-slots (data tracker) this
    (unless (member :data slots)
      (setq data
	    (make-hash-table :size 10000 :rehash-size 2.0 :test 'equal)))
    (unless (member :tracker slots)
      (setq tracker (make-hash-table :size 100 :rehash-size 2.0)))))

That should be 'tracker in that `member', perhaps?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: :tracker in eieio classes

[Eric Abrahamsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Chris Feng <chris.w.feng@gmail.com> writes:
>
>>>> I've noticed that, while tag references to slots work, the compiler
>>>> wants a symbol. I think if you just switch that to (oref db 'tracker) it
>>>> should be quiet. Or (eieio-oref db 'tracker).
>>>
>>> Then it says
>>>
>>> In toplevel form:
>>> gnus/registry.el:182:21:Warning: Unknown slot `(quote tracker)'
>>
>> It should be (oref db tracker).
>
> There's also code like:
>
> (cl-defmethod initialize-instance :after ((this registry-db) slots)
>   "Set value of data slot of THIS after initialization."
>   (with-slots (data tracker) this
>     (unless (member :data slots)
>       (setq data
> 	    (make-hash-table :size 10000 :rehash-size 2.0 :test 'equal)))
>     (unless (member :tracker slots)
>       (setq tracker (make-hash-table :size 100 :rehash-size 2.0)))))
>
> That should be 'tracker in that `member', perhaps?

No, "slots" is a plist, not an object.

Re: :tracker in eieio classes

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> No, "slots" is a plist, not an object.

Okidoke.  I've just changed the `oref' call, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no