From: Lars Ingebrigtsen <larsi@gnus.org>
To: emacs-devel@gnu.org
Subject: Re: Human-readable file sorting
Date: Sat, 20 Feb 2016 17:00:01 +1100 [thread overview]
Message-ID: <87r3g7exb2.fsf@gnus.org> (raw)
In-Reply-To: <m2d1rsnma1.fsf@newartisans.com> (John Wiegley's message of "Fri, 19 Feb 2016 18:33:26 -0800")
John Wiegley <jwiegley@gmail.com> writes:
> If directory-files were made extensible, so a sorting method could be
> provided... that sounds like a nice extension to me. So, having a
> customization variable defaulting to `string-lessp', with an option to switch
> to `string-human-lessp'.
It currently calls `string-lessp' unconditionally, as do all the other
functions that operate on files. This is a very typical example:
(defun image-mode--images-in-directory (file)
(let* ((dir (file-name-directory buffer-file-name))
(files (directory-files dir nil
(image-file-name-regexp) t)))
;; Add the current file to the list of images if necessary, in
;; case it does not match `image-file-name-regexp'.
(unless (member file files)
(push file files))
(sort files 'string-lessp)))
So I think the easiest way to get all this consistent throughout Emacs
isn't to allow `directory-files' to be customisable, but to instead
introduce a new function `file-string-lessp' (or a better name if you
have it), which would basically look like:
(defun file-string-lessp (s1 s2)
(pcase file-sorting-method
(,unicode
(string-lessp s1 s2))
(,human
(human-string-lessp s1 s2)))
..)
(Hey! Did I get the pcase syntax right? Bonus points!)
Then it's "only a matter" of changing these functions to call
`file-string-lessp', and that would include `directory-files'.
(Perhaps it should be in the C layer for speed? Does it matter when
sorting files names? That's probably not the bottleneck...)
> Whether the default should human-lessp is another matter, and something I'd
> instinctively want to defer until feedback.
Sure.
> But having the extensibility does sound nice.
If the proposed method sounds fine, I can start implementing...
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-20 6:00 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 1:15 Human-readable file sorting Lars Ingebrigtsen
2016-02-20 1:58 ` John Wiegley
2016-02-20 2:26 ` Lars Ingebrigtsen
2016-02-20 2:33 ` John Wiegley
2016-02-20 6:00 ` Lars Ingebrigtsen [this message]
2016-02-20 6:12 ` Marcin Borkowski
2016-02-20 7:15 ` Lars Ingebrigtsen
2016-02-20 8:14 ` Marcin Borkowski
2016-02-22 18:09 ` Nikolaus Rath
2016-02-22 21:31 ` Marcin Borkowski
2016-02-23 6:13 ` Yuri Khan
2016-02-23 8:32 ` Andreas Schwab
2016-02-24 5:39 ` Marcin Borkowski
2016-02-20 6:17 ` John Wiegley
2016-02-20 7:11 ` Lars Ingebrigtsen
2016-02-20 9:28 ` Eli Zaretskii
2016-02-20 10:24 ` martin rudalics
2016-02-20 10:53 ` Eli Zaretskii
2016-02-20 17:30 ` Michael Heerdegen
2016-02-20 18:25 ` Drew Adams
2016-02-20 6:16 ` dired and ls (was: Human-readable file sorting) Lars Ingebrigtsen
2016-02-20 6:19 ` dired and ls John Wiegley
2016-02-20 7:25 ` Lars Ingebrigtsen
2016-02-20 8:01 ` John Wiegley
2016-02-23 7:15 ` Thierry Volpiatto
2016-02-23 16:34 ` John Wiegley
2016-02-20 9:57 ` dired and ls (was: Human-readable file sorting) Eli Zaretskii
2016-02-20 19:21 ` dired and ls John Wiegley
2016-02-20 21:02 ` Eli Zaretskii
2016-02-20 21:24 ` John Wiegley
2016-02-21 2:10 ` Lars Ingebrigtsen
2016-02-20 8:53 ` Human-readable file sorting Eli Zaretskii
2016-02-20 11:32 ` Lars Ingebrigtsen
2016-02-20 11:36 ` Eli Zaretskii
2016-02-20 11:45 ` Lars Ingebrigtsen
2016-02-20 12:35 ` Eli Zaretskii
2016-02-21 2:14 ` Lars Ingebrigtsen
2016-02-21 23:36 ` Richard Stallman
2016-02-22 2:58 ` Lars Ingebrigtsen
2016-02-22 18:01 ` Richard Stallman
2016-02-22 18:13 ` Pierpaolo Bernardi
2016-02-22 19:00 ` Eli Zaretskii
2016-02-23 17:43 ` Richard Stallman
2016-02-23 18:00 ` Eli Zaretskii
2016-02-24 1:51 ` Lars Ingebrigtsen
2016-02-24 13:43 ` Richard Stallman
2016-02-24 13:41 ` Richard Stallman
2016-02-20 14:23 ` Alexis
2016-02-20 14:43 ` Eli Zaretskii
2016-02-21 2:18 ` Lars Ingebrigtsen
2016-02-21 9:30 ` Alexis
2016-02-21 10:07 ` Lars Ingebrigtsen
2016-02-21 19:27 ` Yuri Khan
2016-02-21 20:21 ` Eli Zaretskii
2016-02-20 15:35 ` Pierpaolo Bernardi
2016-02-20 15:52 ` Eli Zaretskii
2016-02-21 12:45 ` Richard Stallman
2016-02-20 16:03 ` Herring, Davis
2016-02-20 16:23 ` Paul Eggert
2016-02-21 2:20 ` Lars Ingebrigtsen
2016-02-21 12:45 ` Richard Stallman
2016-02-21 2:38 ` Stefan Monnier
2016-02-20 14:32 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3g7exb2.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.