all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 19853@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#19853: Acknowledgement (25.0.50; ElDoc is displayed whether eldoc-mode is enabled or not)
Date: Tue, 22 Mar 2016 16:29:34 +0100	[thread overview]
Message-ID: <87r3f2pm3l.fsf@web.de> (raw)
In-Reply-To: <871t74lu5n.fsf@web.de> (Michael Heerdegen's message of "Sun, 20 Mar 2016 22:24:36 +0100")

Hi,

maybe we can come to a decision now.

Stefan, you were the one that implemented `global-eldoc-mode', and
decided not to use `define-globalized-minor-mode' to do this.  I think I
understand your intention (use global hook bindings).

The subject of this bug report is that the global eldoc mode behaves
differently from other global modes that have a local counterpart: in
particular, turning off the global mode doesn't turn off the local mode
in all buffers where it is on.  This is somewhat unexpected for the user
and I think more or less only an unintended consequence of the
implementation.

We discussed two alternatives to make the global eldoc mode behave more
like a globalized mode, namely (1) do it indeed with
`define-globalized-minor-mode' and (2)

> > > Hmm, I think the only way out would be to add the stuff to the
> > > global hook bindings unconditionally when eldoc is loaded - no
> > > matter whether the global mode is on or not, and never remove it.
> > > And use only one (buffer local) variable for controlling,
> > > `eldoc-mode', that the local mode sets locally.  The variable
> > > `global-eldoc-mode' would not appear in the code any more.
> > > `global-eldoc-mode' would become a trivial globalized minor mode
> > > that would only turn the local value of `eldoc-mode' in all
> > > buffers.  Would that make sense?

Did we overlook an advantage of your implementation?  Which of these two
alternatives would you prefer?


Thanks,

Michael.





  parent reply	other threads:[~2016-03-22 15:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 11:56 bug#19853: 25.0.50; ElDoc is displayed whether eldoc-mode is enabled or not Dmitry Gutov
     [not found] ` <handler.19853.B.142382861219223.ack@debbugs.gnu.org>
2015-07-21 13:48   ` bug#19853: Acknowledgement (25.0.50; ElDoc is displayed whether eldoc-mode is enabled or not) Dmitry Gutov
2016-03-20 10:00     ` eldoc-mode vs. global-eldoc-mode (was: bug#19853) Marcin Borkowski
2016-03-20 12:41       ` bug#19853: eldoc-mode vs. global-eldoc-mode Dmitry Gutov
2016-03-20 13:17         ` Marcin Borkowski
2016-03-20 13:25           ` Dmitry Gutov
2016-03-20 14:14             ` Marcin Borkowski
2016-03-20 17:08               ` Dmitry Gutov
2016-03-20 10:00     ` bug#19853: eldoc-mode vs. global-eldoc-mode (was: bug#19853) Marcin Borkowski
2016-03-20 18:21     ` bug#19853: Acknowledgement (25.0.50; ElDoc is displayed whether eldoc-mode is enabled or not) Michael Heerdegen
2016-03-20 18:25       ` Dmitry Gutov
2016-03-20 18:34         ` Michael Heerdegen
2016-03-20 18:52           ` Dmitry Gutov
2016-03-20 19:20             ` Michael Heerdegen
2016-03-20 19:27               ` Dmitry Gutov
2016-03-20 19:53                 ` Michael Heerdegen
2016-03-20 20:24                   ` Dmitry Gutov
2016-03-20 21:10                     ` Michael Heerdegen
2016-03-20 21:15                       ` Dmitry Gutov
2016-03-20 21:24                         ` Michael Heerdegen
2016-03-21  4:02                           ` Marcin Borkowski
2016-03-22 15:29                           ` Michael Heerdegen [this message]
2016-03-22 15:38                             ` Stefan Monnier
2016-03-23 15:16                               ` Michael Heerdegen
2016-03-23 15:25                                 ` Dmitry Gutov
2016-03-27  0:31                                 ` John Wiegley
2017-05-29 23:57                                   ` Dmitry Gutov
2017-05-30 22:02                                     ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3f2pm3l.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=19853@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.