From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Considered Harmful 73d213: "Comint, term, and compile new set Emacs" Date: Wed, 06 Apr 2016 18:53:30 +0100 Message-ID: <87r3ei8vz9.fsf@russet.org.uk> References: <87oa9otixb.fsf@russet.org.uk> <5703E15B.7080601@cs.ucla.edu> <87k2kcovt8.fsf@russet.org.uk> <5704233B.4020103@cs.ucla.edu> <8737qzso88.fsf@russet.org.uk> <57045765.4000309@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1459965329 13713 80.91.229.3 (6 Apr 2016 17:55:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Apr 2016 17:55:29 +0000 (UTC) Cc: eggert@penguin.cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 06 19:55:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anrfj-0002Df-Sp for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2016 19:55:20 +0200 Original-Received: from localhost ([::1]:44775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anrfj-0007nK-DG for ged-emacs-devel@m.gmane.org; Wed, 06 Apr 2016 13:55:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anrfV-0007lr-MJ for emacs-devel@gnu.org; Wed, 06 Apr 2016 13:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anrfS-0005OW-EU for emacs-devel@gnu.org; Wed, 06 Apr 2016 13:55:05 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:43383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anrfS-0005J8-4c for emacs-devel@gnu.org; Wed, 06 Apr 2016 13:55:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From; bh=qG+V6/sYXiwRN24aHmhGY6HJBFInRnL050EB/Fji8sk=; b=P3A5JbvFmV/ya9cuJq1Vn5V6cd E4pF3ZOrDf/OnbCBlYB5LdFyvXfEXYk59x24dsHx1PnEJ8Z2ugYXNr6pRtG8SVjmD9+aCwunrYnY6 +qvqn7qTWLkCopnbOjXaHc5Ea51aZS1nWIwb9RuFvori+BachPg7qonHFa2rA+nhK4F03I+Fj0g74 zGoR/rm6ytH5+TyE8+NC+ukWCbvMIU/QuKdPHiBDXCDBCArR0i0vEbGfXNEnyxqkreTZLClULC4M4 J4qx64GRqfoqW1bxn502BOb66qWG2Fqfz+rFcz2nzpNNyZ7IhbZqv3A5j6hNxcPY6sp9YAbwFps6F L48ex5hw==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:45105 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1anrel-000B2w-TT; Wed, 06 Apr 2016 18:54:20 +0100 In-Reply-To: <57045765.4000309@cs.ucla.edu> (Paul Eggert's message of "Tue, 5 Apr 2016 17:25:09 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 31.216.48.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202772 Archived-At: Paul Eggert writes: > On 04/05/2016 03:08 PM, Phillip Lord wrote: >> The main problem is that use of cask tends to weave in and out of >> different Emacs and also Makefiles. So, I use this: >> >> EMACS ?= emacs >> CASK ?= cask >> >> -include makefile-local >> >> all: install test >> >> install: >> EMACS=$(EMACS) cask install >> >> Which (did) work fine on Emacs-25 > > But that doesn't work on Emacs 24, right? It doesn't have to work on Emacs-24. I don't use Emacs-24 to develop in, only Emacs-25, at least partly because Emacs-25 doesn't (didn't) set EMACS=t. > And if you do something like the > following: > > EMACS ?= emacs > CASK ?= cask > > ifeq ($(EMACS),t) > EMACS = emacs > endif > > install: > EMACS=$(EMACS) cask install > > This should work with both Emacs 24 and emacs-25 current. At this juncture, I think the sensible thing is to give up on using EMACS as both an environment variable and a makefile variable. Putting hacks into my make file to distinguish between running inside and outside of Emacs is not a solution. The same make file should work. To repeat, my belief is that a behaviour that was installed deliberately, and which has been on master/emacs-25 for a year should not have been removed in pre-test. I think Stefan's patch needs restoring. Are you prepared to do this? Failing that, I will back out my changes to cask. Phil