Re: Considered Harmful 73d213: "Comint, term, and compile new set Emacs"

[phillip.lord@russet.org.uk (Phillip Lord)]

Paul Eggert <eggert@cs.ucla.edu> writes:

> On 04/05/2016 03:08 PM, Phillip Lord wrote:
>> The main problem is that use of cask tends to weave in and out of
>> different Emacs and also Makefiles. So, I use this:
>>
>> EMACS ?= emacs
>> CASK ?= cask
>>
>> -include makefile-local
>>
>> all: install test
>>
>> install:
>> 	EMACS=$(EMACS) cask install
>>
>> Which (did) work fine on Emacs-25
>
> But that doesn't work on Emacs 24, right?

It doesn't have to work on Emacs-24. I don't use Emacs-24 to develop in,
only Emacs-25, at least partly because Emacs-25 doesn't (didn't) set
EMACS=t. 


> And if you do something like the
> following:
>
>     EMACS ?= emacs
>     CASK ?= cask
>
>     ifeq ($(EMACS),t)
>       EMACS = emacs
>     endif
>
>     install:
>         EMACS=$(EMACS) cask install
>
> This should work with both Emacs 24 and emacs-25 current.

At this juncture, I think the sensible thing is to give up on using
EMACS as both an environment variable and a makefile variable. Putting
hacks into my make file to distinguish between running inside and
outside of Emacs is not a solution. The same make file should work.

To repeat, my belief is that a behaviour that was installed
deliberately, and which has been on master/emacs-25 for a year should
not have been removed in pre-test. I think Stefan's patch needs
restoring. Are you prepared to do this?

Failing that, I will back out my changes to cask.

Phil