all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: phillip.lord@russet.org.uk (Phillip Lord)
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: eggert@penguin.cs.ucla.edu, monnier@iro.umontreal.ca,
	emacs-devel@gnu.org
Subject: Re: Considered Harmful 73d213: "Comint, term, and compile new set Emacs"
Date: Wed, 06 Apr 2016 18:53:30 +0100	[thread overview]
Message-ID: <87r3ei8vz9.fsf@russet.org.uk> (raw)
In-Reply-To: <57045765.4000309@cs.ucla.edu> (Paul Eggert's message of "Tue, 5 Apr 2016 17:25:09 -0700")


Paul Eggert <eggert@cs.ucla.edu> writes:

> On 04/05/2016 03:08 PM, Phillip Lord wrote:
>> The main problem is that use of cask tends to weave in and out of
>> different Emacs and also Makefiles. So, I use this:
>>
>> EMACS ?= emacs
>> CASK ?= cask
>>
>> -include makefile-local
>>
>> all: install test
>>
>> install:
>> 	EMACS=$(EMACS) cask install
>>
>> Which (did) work fine on Emacs-25
>
> But that doesn't work on Emacs 24, right?

It doesn't have to work on Emacs-24. I don't use Emacs-24 to develop in,
only Emacs-25, at least partly because Emacs-25 doesn't (didn't) set
EMACS=t. 


> And if you do something like the
> following:
>
>     EMACS ?= emacs
>     CASK ?= cask
>
>     ifeq ($(EMACS),t)
>       EMACS = emacs
>     endif
>
>     install:
>         EMACS=$(EMACS) cask install
>
> This should work with both Emacs 24 and emacs-25 current.

At this juncture, I think the sensible thing is to give up on using
EMACS as both an environment variable and a makefile variable. Putting
hacks into my make file to distinguish between running inside and
outside of Emacs is not a solution. The same make file should work.

To repeat, my belief is that a behaviour that was installed
deliberately, and which has been on master/emacs-25 for a year should
not have been removed in pre-test. I think Stefan's patch needs
restoring. Are you prepared to do this?

Failing that, I will back out my changes to cask.

Phil








  reply	other threads:[~2016-04-06 17:53 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-05 11:05 Considered Harmful 73d213: "Comint, term, and compile new set Emacs" Phillip Lord
2016-04-05 16:01 ` Paul Eggert
2016-04-05 16:38   ` Phillip Lord
2016-04-05 20:42     ` Paul Eggert
2016-04-05 22:08       ` Phillip Lord
2016-04-06  0:25         ` Paul Eggert
2016-04-06 17:53           ` Phillip Lord [this message]
2016-04-07  1:05             ` Paul Eggert
2016-04-07  7:18               ` Considered Harmful 73d213: 'Comint, term, and compile new set Emacs' Phillip Lord
2016-04-07 14:57                 ` bug#20202: " Paul Eggert
2016-04-07  7:35               ` Phillip Lord
2016-04-07 15:01                 ` bug#20202: " Paul Eggert
2016-04-07 15:18                   ` Phillip Lord
2016-04-07 15:25                     ` Paul Eggert
2016-04-07 16:01                       ` Glenn Morris
2016-04-07 16:07                       ` Phillip Lord
2016-04-07 16:26                         ` bug#20484: " Paul Eggert
2016-04-07 19:55                           ` Phillip Lord
2016-04-07 22:20                             ` bug#20484: " Stefan Monnier
2016-04-08  7:05                               ` Eli Zaretskii
2016-04-08 13:09                               ` Phillip Lord
2016-04-08 20:50                                 ` Paul Eggert
2016-04-08 21:20                                   ` Phillip Lord
2016-04-08  7:03                             ` bug#20484: " Eli Zaretskii
2016-04-08  7:34                             ` Andreas Schwab
2016-04-08 13:12                               ` bug#20484: " Phillip Lord
2016-04-07 21:42                           ` Phillip Lord
2016-04-08  7:01                             ` Eli Zaretskii
2016-04-08 16:49                               ` bug#20202: " Stefan Monnier
2016-04-08 18:12                                 ` Phillip Lord
2016-04-07 16:51                       ` Stefan Monnier
2016-04-07 16:59                         ` bug#20202: " Eli Zaretskii
2016-04-07 18:58                           ` Stefan Monnier
2016-04-07 19:25                             ` Eli Zaretskii
2016-04-07 22:01                               ` Stefan Monnier
2016-04-08  7:00                                 ` bug#20202: " Eli Zaretskii
2016-04-08 15:32                                   ` Glenn Morris
2016-04-08 15:59                                     ` Eli Zaretskii
2015-05-01 23:36                                       ` bug#20484: 25.0.50; Directory tracking in ansi-term broken Jacob Oursland
2015-05-02  2:17                                         ` Glenn Morris
2015-05-02  2:43                                           ` Glenn Morris
2015-05-02 19:33                                             ` Jacob Oursland
2015-05-03  5:45                                               ` Stefan Monnier
2015-05-03  6:15                                                 ` Jacob Oursland
2015-05-03 16:29                                                 ` Richard Stallman
2015-05-03 17:36                                                   ` Jacob Oursland
2015-05-04  2:06                                                   ` Stefan Monnier
2015-05-04 16:15                                                     ` Richard Stallman
2015-05-03 17:57                                                 ` Glenn Morris
2015-05-03 19:09                                                   ` Jacob Oursland
2015-05-04  2:07                                                   ` Stefan Monnier
2016-03-23 22:15                                         ` Paul Eggert
2016-04-08 18:47                                         ` bug#20484: Bash 4.4-rc1 incompatibility with future Emacs $EMACS Paul Eggert
2016-04-09  2:24                                         ` bug#20484: bug#20202: Considered Harmful 73d213: 'Comint, term, and compile new set Emacs' Glenn Morris
2016-04-09  8:43                                           ` Phillip Lord
2016-04-09 13:43                                           ` bug#20202: " Stefan Monnier
2016-04-09 21:56                                             ` Phillip Lord
2016-04-09 23:40                                               ` bug#20202: " Paul Eggert
2016-04-10  0:08                                                 ` Stefan Monnier
2016-04-10  3:30                                                   ` Paul Eggert
2016-04-10 13:57                                                     ` Stefan Monnier
2016-04-11  5:50                                                       ` bug#20202: " Paul Eggert
2016-04-10  8:26                                                   ` bug#20484: " Phillip Lord
2016-04-10 13:59                                                     ` Stefan Monnier
2016-04-11 12:32                                                       ` bug#20484: " Phillip Lord
2016-04-10  8:25                                                 ` Phillip Lord
2015-03-25 21:44                                                   ` bug#20202: 24.3; Comint mode sets a bad $EMACS Eli Barzilay
2015-03-26  0:46                                                     ` Stefan Monnier
2015-03-28 15:27                                                       ` Eli Barzilay
2015-04-09 15:02                                                         ` Stefan Monnier
2016-04-10 12:18                                                     ` bug#20202: bug#20484: bug#20202: Considered Harmful 73d213: 'Comint, term, and compile new set Emacs' Markus Triska
2016-04-11 12:38                                                       ` Phillip Lord
2018-05-24 20:46                                                     ` bug#20202: EMACS=t Joy and Happiness Phillip Lord
2016-04-10  7:13                                               ` bug#20202: bug#20484: bug#20202: Considered Harmful 73d213: 'Comint, term, and compile new set Emacs' Michael Albinus
2016-04-10  8:51                                                 ` Phillip Lord
2016-04-10  9:31                                                   ` Michael Albinus
2016-04-08 16:46                                   ` Stefan Monnier
2016-04-08 17:12                                     ` Paul Eggert
2016-04-08 18:14                                       ` bug#20202: " Phillip Lord
2016-04-08 17:47                                     ` Phillip Lord
2016-04-08 13:15                               ` Phillip Lord
2016-04-08 13:40                                 ` Eli Zaretskii
2016-04-08 15:45                                   ` bug#20202: " Glenn Morris
2016-04-08 16:01                                     ` Eli Zaretskii
2016-04-07 15:07                 ` Eli Zaretskii
2016-04-07 15:21                   ` Phillip Lord
2016-04-07 15:26                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r3ei8vz9.fsf@russet.org.uk \
    --to=phillip.lord@russet.org.uk \
    --cc=eggert@cs.ucla.edu \
    --cc=eggert@penguin.cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.