From: npostavs@users.sourceforge.net
To: martin rudalics <rudalics@gmx.at>
Cc: 24213@debbugs.gnu.org, Leo Liu <sdl.web@gmail.com>,
Andreas Politz <politza@hochschule-trier.de>
Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el
Date: Sat, 13 Aug 2016 08:44:54 -0400 [thread overview]
Message-ID: <87r39sx2gp.fsf@users.sourceforge.net> (raw)
In-Reply-To: <57AED974.4030900@gmx.at> (martin rudalics's message of "Sat, 13 Aug 2016 10:25:24 +0200")
martin rudalics <rudalics@gmx.at> writes:
>> Maybe the documentation of delte-window should be amended, stating that
>> it is almost always preferable to use quit-window instead;
>
> ‘delete-window’ is primarily a command bound to C-x 0. It should be
> used only sparingly in Elisp code. Nevertheless, I think that any
> advice to use ‘quit-window’ instead should go to the ‘display-buffer’
> group functions because ‘quit-window’ (now) inherently belongs there.
Wouldn't it then make sense to add the usual "if you are thinking of
using this function from Lisp code, it's probably a mistake, try
`quit-window' instead" warning to the delete-window's docstring?
(also, doc fixes should go to emacs-25, right?)
next prev parent reply other threads:[~2016-08-13 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 20:22 bug#24213: 25.1.50; Fishy use of delete-window in register.el Andreas Politz
2016-08-13 2:39 ` Leo Liu
2016-08-13 6:43 ` Andreas Politz
2016-08-13 8:25 ` martin rudalics
2016-08-13 12:44 ` npostavs [this message]
2016-08-13 12:51 ` Eli Zaretskii
2016-08-13 13:30 ` martin rudalics
2016-08-13 9:50 ` Leo Liu
2016-08-13 8:24 ` martin rudalics
2016-08-13 9:50 ` Leo Liu
2016-08-13 8:24 ` martin rudalics
2016-08-13 8:47 ` Andreas Politz
2016-08-13 10:03 ` martin rudalics
2016-08-31 19:04 ` Andreas Politz
2016-09-01 7:40 ` martin rudalics
2016-09-01 11:22 ` Andreas Politz
2016-09-01 12:57 ` martin rudalics
2019-09-29 14:58 ` Lars Ingebrigtsen
2019-10-13 3:09 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r39sx2gp.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24213@debbugs.gnu.org \
--cc=politza@hochschule-trier.de \
--cc=rudalics@gmx.at \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.